Do not early return on null bucket_ptr
#68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
force-pushed
the
no-early-return
branch
from
d70ef32 to
8130104
Compare
Swatinem
force-pushed
the
no-early-return
branch
from
8130104 to
d54b6f5
Compare
Amanieu
reviewed
Feb 12, 2024
Swatinem
force-pushed
the
no-early-return
branch
from
d54b6f5 to
d4b3def
Compare
Owner
|
LGTM once CI is fixed by #69. |
Buckets are allocated on demand based on `Thread::bucket`. This means that when only threads with a high `id` (and thus high `bucket`) are writing entries into the `ThreadLocal`, only higher `buckets` will be allocated, and lower buckets will be `null`. Thus we must not early-return when encounting a `null` bucket.
Amanieu
force-pushed
the
no-early-return
branch
from
d4b3def to
b197719
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buckets are allocated on demand based on
Thread::bucket. This means that when only threads with a highid(and thus highbucket) are writing entries into theThreadLocal, only higherbucketswill be allocated, and lower buckets will benull.Thus we must not early-return when encounting a
nullbucket.This seems to be a regression introduced in #51 and #53, and should fix #54.