Skip to content

[cttq] fix: When create redis_conn,check if connection already exists #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
warning128 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[cttq] fix: When create redis_conn,check if connection already exists #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions internal/mcp/session/redis.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,6 +254,26 @@ func (s *RedisStore) Get(ctx context.Context, id string) (Connection, error) {
return nil, ErrSessionNotFound
}

// First check if connection already exists in our active connections map
s.mu.RLock()
if conn, exists := s.connections[id]; exists {
s.mu.RUnlock()
// Renew TTL for both the session data and the session ID in the set
key := s.prefix + id
if err := s.client.Expire(ctx, key, s.ttl).Err(); err != nil {
s.logger.Warn("failed to renew session TTL",
zap.String("id", id),
zap.Error(err))
}
if err := s.client.Expire(ctx, s.prefix+"ids", s.ttl).Err(); err != nil {
s.logger.Warn("failed to renew session ID set TTL",
zap.String("id", id),
zap.Error(err))
}
return conn, nil
}
s.mu.RUnlock()

key := s.prefix + id
data, err := s.client.Get(ctx, key).Bytes()
if err != nil {
Expand Down