Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme.md #221

Merged
merged 1 commit into from
Feb 18, 2025
Merged

readme.md #221

merged 1 commit into from
Feb 18, 2025

Conversation

Daymox
Copy link
Contributor

@Daymox Daymox commented May 7, 2024

No description provided.

@rbrouwer
Copy link

rbrouwer commented May 7, 2024

I would suggest changing the title of that example.

250831 has check digit 5 and both of those are used in the MRZ key below it. Making that 250830 would mean the check digit would be 4 (line below) and the MRZ key 12345678898012772508304

Therefore changing "Expiry 30-Aug-2025" -> "Expiry 31-Aug-2025" would probably be easier. Your intention is good, but in its current form it is incomplete and does not completely fix the example.

@AndyQ AndyQ merged commit ad33ea7 into AndyQ:main Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants