chore: Refactor imports#107
Merged
Merged
Conversation
Refactor imports and function calls to adopt a more concise yet still meaningful style. General guidelines: - Import modules (using `use ...`) at the top. - When calling a function, keep module name when it provides useful context / provenance, e.g. `env::var()`, `io::stdout()`, `fs::read_to_string()`. - If the function has an associated type, prefer using function name + type directly instead, e.g. `ErrorKind::NotFound`, `HashMap::new()`, `PathBuf::from()`, `Uid::effective()`. As a *general* rule of thumb, avoid deeply qualified paths and aim for roughly one `::` per call (e.g. prefer `ErrorKind::NotFound` over `std::io::ErrorKind::NotFound`). Exceptions can be made fine when it avoids ambiguity (such as conflicting functions names, e.g. `std::thread::sleep` vs `tokio::time::sleep`), or when a function call is already clear (from name or context) and the refactor doesn't bring much (for instance, the single `get(&url)` call from the current codebase).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor imports and function calls to adopt a more concise yet still meaningful style.
General guidelines:
use ...) at the top.env::var(),io::stdout(),fs::read_to_string().ErrorKind::NotFound,HashMap::new(),PathBuf::from(),Uid::effective().As a general rule of thumb, avoid deeply qualified paths and aim for roughly one
::per call (e.g. preferErrorKind::NotFoundoverstd::io::ErrorKind::NotFound).Exceptions can be made fine when it avoids ambiguity (such as conflicting functions names, e.g.
std::thread::sleepvstokio::time::sleep), or when a function call is already clear (from name or context) and the refactor doesn't bring much (for instance, the singleget(&url)call from the current codebase).