feat: Add jina v3 support #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm @Anush008, is it running out of disk space? |
|
I am not sure why the failure. |
|
Ah, file retrieval is selective, makes sense. Still not able to run the full tests locally so this might take a while 👯 |
|
@Anush008 I'm a bit at a loss at this point. Previous commit said it expected a dim of {3, 1 ,1, 1024 } for the task ids. Changed the dims to match the rest, now it gives an out of bounds error with no clear indiciation where. I have honestly zero clues. Do you have any? Otherwise maybe worth it to split v2/v3, as v2 seems to pass (since the start). |
timonv
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for jina v2 code and jina v3, both popular and well ranking models.
I'm struggling a bit with the tests on my mac, getting some varied result. Last time on linux that wasn't an issue. Even though the Jina tests seem to pass.