This repository was archived by the owner on Jun 6, 2024. It is now read-only.
fix: proper gas estimation #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca11ab1e
force-pushed
the
fix-52-gas-estimation-devnet
branch
from
025d2fb to
dcd66e7
Compare
Also unlock gas estimation on the devnet.
ca11ab1e
force-pushed
the
fix-52-gas-estimation-devnet
branch
from
dcd66e7 to
c75f81e
Compare
It doesn't make sense to estimate gas for non-signed transactions.
ca11ab1e
force-pushed
the
fix-52-gas-estimation-devnet
branch
from
964e2a0 to
c461457
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
antazoey
reviewed
Jul 18, 2022
antazoey
reviewed
Jul 18, 2022
ca11ab1e
commented
Jul 19, 2022
…ab1e/ape-starknet into fix-52-gas-estimation-devnet
This comment was marked as outdated.
This comment was marked as outdated.
It seems to still be fixed to 100 gwei though.
ca11ab1e
force-pushed
the
fix-52-gas-estimation-devnet
branch
from
8323fda to
f6a9309
Compare
This comment was marked as outdated.
This comment was marked as outdated.
antazoey
reviewed
Aug 1, 2022
ape_starknet/provider.py
Outdated
| **NOTE**: Currently, the gas price is fixed to always be 100 gwei. | ||
| """ | ||
| return self.conversion_manager.convert("100 gwei", int) | ||
| return self.current_gas_price |
There was a problem hiding this comment.
It would be better to get the value from a block:
https://github.com/software-mansion/starknet.py/pull/279/files
Otherwise this can be outdated and is only set once a transaction is made.
There was a problem hiding this comment.
Good point. I'll simply revert that change, it was out of the scope anyway. Let's tackle that in a specific PR when starknet.py will be ready (cf #80).
antazoey
approved these changes
Aug 1, 2022
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
fixes: #52
Ideally, that PR would:
How I did it
How to verify it
Checklist