alerts manager of inactivity #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to alert managers about engineers who have been inactive (no completed Linear issues) in the last 7 days. The system now sends these alerts to a separate manager Slack webhook on Fridays.
- Introduces a new function to track and report engineer inactivity to managers
- Adds a dedicated Slack webhook for manager notifications
- Includes minor code formatting improvements and import reorganization
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| jobs.py | Adds inactive engineer tracking with manager notifications, new Slack webhook function, and minor formatting improvements |
| README.md | Removes trailing whitespace from documentation |
| response.raise_for_status() | ||
|
|
||
|
|
||
| def post_to_manager_slack(markdown: str): |
There was a problem hiding this comment.
The function lacks a docstring explaining its purpose and parameters. Consider adding documentation similar to the existing post_to_slack function.
| try: | ||
| completed = get_completed_issues_for_person(login, 7) | ||
| except Exception as e: | ||
| logging.error(f"Failed to fetch completed issues for {login}: {e}") |
There was a problem hiding this comment.
Using f-string in logging.error can cause issues if the variables contain format specifiers. Use logging.error("Failed to fetch completed issues for %s: %s", login, e) instead.
Suggested change
| logging.error(f"Failed to fetch completed issues for {login}: {e}") | |
| logging.error("Failed to fetch completed issues for %s: %s", login, e) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.