Skip to content

Conversation

@redreceipt
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings July 30, 2025 20:19
@redreceipt redreceipt temporarily deployed to bug-board-project-param-518fcb July 30, 2025 20:19 Inactive
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds cycle work to the changelog by implementing filtering logic that includes issues from cycle initiative projects alongside non-project issues. The PR modifies issue queries to fetch project information and implements filtering based on configured cycle initiatives.

  • Removes project filtering from the main query and adds post-processing to normalize project data
  • Implements cycle initiative filtering in the weekly changelog function to include relevant project issues
  • Filters out project issues from the index summary to maintain current behavior for the main dashboard

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
linear.py Removes project filter from query, adds project field to response, and normalizes project data
jobs.py Adds cycle initiative filtering logic to include relevant project issues in weekly changelog
app.py Filters out project issues from index summary to maintain current dashboard behavior

state: { name: { in: ["Done"] } }
completedAt:{gt: $days}
project: { null: true }
completedAt: { gt: $days }
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the project filter changes the query behavior significantly. This could impact performance as it will now fetch all completed issues regardless of project status, then filter them post-query. Consider if this filtering could be done more efficiently at the GraphQL level.

Suggested change
completedAt: { gt: $days }
completedAt: { gt: $days }
project: { name: { eq: $project } }

Copilot uses AI. Check for mistakes.
config = load_config()
cycle_init = config.get("cycle_initiative")
if cycle_init:
projects = get_projects()
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The get_projects() call is made inside the filtering logic but the result is only used when cycle_init is configured. Consider moving this call inside the if cycle_init block to avoid unnecessary API calls when no cycle initiative is configured.

Copilot uses AI. Check for mistakes.
@redreceipt redreceipt merged commit 2bd08cb into main Jul 30, 2025
2 checks passed
@redreceipt redreceipt deleted the project-param branch July 30, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants