add crossroads to list of repos #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the repository tracking functionality to support repositories from different GitHub organizations by modifying the repo list format and query structure.
- Updates repository entries from just names to full "owner/name" format
- Adds "differential/crossroads-anywhere" to the tracked repositories
- Refactors GraphQL query to accept both owner and name parameters instead of hardcoding "apollosproject"
| continue | ||
| params = {"owner": owner, "name": name} | ||
| data = client.execute(repo_id_query, variable_values=params) | ||
| ids.append(data["repository"]["id"]) |
There was a problem hiding this comment.
This line will raise a KeyError if the repository is not found (e.g., if it's private or doesn't exist), since data["repository"] will be None. Consider adding a null check before accessing the id.
Suggested change
| ids.append(data["repository"]["id"]) | |
| if data.get("repository") is not None: | |
| ids.append(data["repository"]["id"]) | |
| else: | |
| # Repository not found or inaccessible; skip this entry. | |
| continue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.