Skip to content

Conversation

@redreceipt
Copy link
Member

Summary

  • raise the final exception in with_retries so callers know a job failed
  • remove the run_job scheduler wrapper so errors surface directly

Testing

  • pip install -r requirements.txt
  • pip install -r requirements.dev.txt (fails: Tunnel connection failed)
  • flake8 (command not found)

https://chatgpt.com/codex/tasks/task_e_688a829406548324b51705ac7564e48d

Copilot AI review requested due to automatic review settings July 30, 2025 20:48
@redreceipt redreceipt temporarily deployed to bug-board-codex-modify--r4wqnp July 30, 2025 20:48 Inactive
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves error handling in the retry wrapper by ensuring that the final exception is raised to the caller when all retry attempts are exhausted, rather than silently failing.

  • Adds explicit exception raising after the final retry attempt fails
  • Removes silent failure behavior that would prevent callers from knowing a job failed

return func(*args, **kwargs)
except Exception as e:
logging.error(f"Function {func.__name__} failed: {e}")
if i == 2:
Copy link

Copilot AI Jul 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded value '2' creates a magic number that's unclear. Consider using a variable like 'max_retries - 1' or adding a comment to explain that this represents the final retry attempt.

Copilot uses AI. Check for mistakes.
@redreceipt redreceipt merged commit dec0274 into main Jul 30, 2025
2 checks passed
@redreceipt redreceipt deleted the codex/modify-with_retries-to-raise-last-exception branch July 30, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants