[RFC] Port to machine agents shipping Java 11 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Java 11 does not supply a SOAP implementation, unlike Java 8. A choice was made to go with the latest libraries from the Eclipse Metro project to avoid security vulnerabilities associated with old and deprecated versions. This breaks compatibility with Java 8 and Java 11+ is now required, which explains bumping the major version of the extension. This change also deals with issues resulting from the way the machine agent loads extensions, along with interactions between thread pools and class loaders in Java 9 and above. It ensures SOAP handling initialization does not happen in the constructor of the extension's main class, otherwise the class loader will fail to locate certain classes when launched via the machine agent (although tests pass).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tentative fix for issues running the extension on agents based on Java 11. This requires testing in an actual DataPower environment, only minimal testing was done to see if it attempts to connect to a DataPower endpoint using plain
socatas a server. Update the PR and merge appropriately once that's done. Also check out the commit description for details.Black Duck scan for completeness: https://blackduck.corp.appdynamics.com/api/projects/783bbd22-3fe9-4815-839b-fdfd7c2ad32c/versions/96f6b796-b0a3-49e0-92b1-a55deb841fc1/components (EDIT: fixed link)