-
Notifications
You must be signed in to change notification settings - Fork 1.4k
TWW: Support launcher command line arguments #5806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
nicholassaylor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
duckboycool
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to pass args now (and have --nogui actually let you type now). The changes here are also just standard for this issue.
silasary
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks pretty standard
What is this fixing or adding?
Reference: https://discord.com/channels/731205301247803413/1451034866425528370/1451034866425528370
This PR adds support for command line arguments being provided to the client by the launcher. Previously, you would get an error like
TypeError: run_client() takes 0 positional arguments but # were given.How was this tested?
Ran the launcher for the client with
--connect,--password,--noguiarguments and it seemed to work. Ran the client through the launcher too to make sure that works. Didn't test much more than that.If this makes graphical changes, please attach screenshots.
N/A