Skip to content

Conversation

@tanjo3
Copy link
Contributor

@tanjo3 tanjo3 commented Jan 1, 2026

What is this fixing or adding?

Reference: https://discord.com/channels/731205301247803413/1451034866425528370/1451034866425528370

This PR adds support for command line arguments being provided to the client by the launcher. Previously, you would get an error like TypeError: run_client() takes 0 positional arguments but # were given.

How was this tested?

Ran the launcher for the client with --connect, --password, --nogui arguments and it seemed to work. Ran the client through the launcher too to make sure that works. Didn't test much more than that.

If this makes graphical changes, please attach screenshots.

N/A

@github-actions github-actions bot added the waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. label Jan 1, 2026
Copy link
Contributor

@nicholassaylor nicholassaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@duckboycool duckboycool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to pass args now (and have --nogui actually let you type now). The changes here are also just standard for this issue.

@duckboycool duckboycool added is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer. and removed waiting-on: peer-review Issue/PR has not been reviewed by enough people yet. labels Jan 8, 2026
Copy link
Collaborator

@silasary silasary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks pretty standard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

is: bug/fix Issues that are reporting bugs or pull requests that are fixing bugs. waiting-on: core-review Issue/PR has been peer-reviewed and is ready to be merged or needs input from a core maintainer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants