The Messenger: Fix lambda capture issue in add_closed_portal_reqs #5816
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I wrote a fuzzer hook for detecting lambda capture issues and it identified this case in add_closed_portal_reqs where each rule would end up using the last value of `portal` in the loop.
github-actions
bot
added
the
waiting-on: peer-review
Contributor
Author
alwaysintreble
approved these changes
Jan 3, 2026
duckboycool
added
the
is: bug/fix
lgbarrere
approved these changes
Jan 9, 2026
Contributor
lgbarrere
left a comment
lgbarrere
left a comment
There was a problem hiding this comment.
Short and transparent modification at AP side. Looks good to me.
nicholassaylor
approved these changes
Jan 12, 2026
duckboycool
added
waiting-on: core-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
I wrote a fuzzer hook for detecting lambda capture issues and it identified this case in
add_closed_portal_reqswhere each rule would end up using the last value ofportalin the loop.How was this tested?
All I've done is run some generations with the fuzzer. I don't know enough about The Messenger to test it properly, or to know what impact this issue would have had on generation.