Core: replace the eval in OptionsCreator.py #5828
Open
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Replaces the
evalin OptionsCreator.py with converting strings toint/booldirectly.eval, while probably safe here, can be a security concern, which could have complicated maintenance and/or refactors.How was this tested?
I clicked the "Random?" button on numeric, boolean and other options, with extra logging to log the new value of
self.options[name]each time, and which conditional branch was being hit.