3 KH2 Client Bugfixes - #6373
Open
shananas wants to merge 1 commit into
Open
Conversation
… (except for the very next line) kh2_client_settings var, fix infinite loop if a playername has a { in it by just removing the code for special commands since none are currently implemented and Lua Socket version will replace this anyways.
Contributor
Author
github-actions
Bot
added
the
waiting-on: peer-review
duckboycool
added
is: bug/fix
Collaborator
|
I approve this pr |
duckboycool
removed
the
waiting-on: world-maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this fixing or adding?
Actually load client settings when starting KH2 Client, Remove unused (except for the very next line) kh2_client_settings var, fix infinite loop if a playername has a { in it by just removing the code for special commands since none are currently implemented and Lua Socket version will replace this any ways. Also acutally dont show in game notifications when setting to none.
How was this tested?
Ran a test seed before these changes with 2 players one with {1} in it as is the common mistake. Saw the infinite loop and client crash. Also saw the notification settings weren't loaded and that setting popups to none still displayed them. After the code changes observe that {} are just replaced with spaces and didnt cause an infinite loop, client settings properly loaded and saved, and setting notifs to none actually made the item notifications not display.
If this makes graphical changes, please attach screenshots.