Core: GUI/Kivy: Change some static default and hard-coded colors to use dynamic colors - #6382
Open
aidanii24 wants to merge 3 commits into
Open
Core: GUI/Kivy: Change some static default and hard-coded colors to use dynamic colors#6382aidanii24 wants to merge 3 commits into
aidanii24 wants to merge 3 commits into
Conversation
…ce from theme_cls instead kvui/Launcher: Moved hardcoded background colors to client.kv/launcher.kv
kv: Changed text color for SelectableLabel
github-actions
Bot
added
affects: core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces some default colors in
client.kvandlauncher.kvto instead source from KivyMD ThemeManager's dynamic colors. Some colors hardcoded inkvui.pyandLauncher.pyhave also been moved to their respective KV files.What is this fixing or adding?
This allows the Archipelago GUI to be able to better adapt to user preferences. Most importantly though, GameManager-inheriting Clients can now automatically set the color for the
SelectableLabelwidget. That widget was by default set to a static value of(1, 1, 1, 1), which made it invisible. With this change, users who opt into Light mode will no longer need to change that widget color as well just to read the text in most clients.Accompanying changes were made for consistency and aesthetics. Such changes are kept to a minimum.
How was this tested?
I tested both Light and Dark versions of
Lightsteelblue,Red,Violet,GreenandOliveon the Launcher and the Text Client. Options Creator and the OoT Client were also tested to a much lesser degree. Personally, legibility and contrast across all combinations are kept solid and high. These tests were performed on my machine, running Fedora 44 KDE.Unittests were performed and run by GitHub Actions upon push. They all passed, though one test did need to be rerun before passing. (Python 3.13 - Windows Latest).
If this makes graphical changes, please attach screenshots.
Provided screenshots showcase both Light and Dark versions of
LightsteelblueandRedwith the PR applied.Additionally, the following is a screenshot from the 0.6.7 tarball, when using
Redin Light Mode, to showcase the problem trying to be fixed.