WARC Fixes: Payload hash and CDX records#360
Open
Frogging101 wants to merge 2 commits intoArchiveTeam:masterfrom
Open
WARC Fixes: Payload hash and CDX records#360Frogging101 wants to merge 2 commits intoArchiveTeam:masterfrom
Frogging101 wants to merge 2 commits intoArchiveTeam:masterfrom
Conversation
…espace The payload offset was being obtained by taking len(response.to_bytes()), but since leading/trailing whitespace is discarded from the response class's name/value pairs, the length of the generated string would not necessarily reflect the actual size of the received headers, leading to a checksum being calculated from the wrong position in the file. To prevent this, the WARC recorder will now independently figure out where the headers really end in the file.
The regex used to find the end of the HTTP headers would not match if there was a newline in between, so get_http_header would return nothing and the status code and MIME type fields would be empty in the CDX record.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I remembered to:
developand set to merge intodevelopChanges: