Repository navigation
Remove app snippets - #25
Closed
ArekBalysNordic wants to merge 2 commits into
Closed
ArekBalysNordic wants to merge 2 commits into
ArekBalysNordic wants to merge 2 commits into
Conversation
| @@ -8,4 +8,4 @@ | |||
| CONFIG_CHIP_ICD_LIT_SUPPORT=y | |||
| CONFIG_CHIP_ICD_SIT_SLOW_POLL_LIMIT=5000 | |||
| CONFIG_CHIP_ICD_REPORT_ON_ACTIVE_MODE=y | |||
| CONFIG_NCS_SAMPLE_MATTER_ZAP_FILE_PATH="${APPLICATION_CONFIG_DIR}/snippets/lit_icd/light_switch.zap" | |||
| CONFIG_NCS_SAMPLE_MATTER_ZAP_FILE_PATH="${APPLICATION_CONFIG_DIR}/src/lit_icd_zap/light_switch.zap" | |||
Collaborator
There was a problem hiding this comment.
I think we agreed that light switch is a device type that could be LIT by default, so I think we could just enable it and do not maintain two options.
Changed application snippets to overlay.conf files. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
- Converted sample-specific snippets to overlays. - Moved common snippets to the global snippet directory. - Aligned documentation. Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
ArekBalysNordic
force-pushed
the
remove_app_snippets
branch
from
February 23, 2026 14:09
fb32116 to
0b93ecf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.