-
Notifications
You must be signed in to change notification settings - Fork 19
Article review - minor fixes #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
suren-atoyan
wants to merge
4
commits into
Argo-Robot:main
Choose a base branch
from
Cyber-Fusion:suren-atoyan/article-review-minor-fixes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
| <img src="./images/sim.gif" alt="Global Trajectory" style="width:80%; height:auto;"> | ||
| </div><br> | ||
|
|
||
| Mobile robotics has reached a huge turning point. Thanks to the development and improvment of parallel computation and deep learning, robots are now able to learn complex tasks such as walking, running and jumping. The applications are endless, such as: ispection, search-and-rescue missions, entertainment and even healthcare. | ||
| Mobile robotics has reached a huge turning point. Thanks to the development and improvment of parallel computation and deep learning, robots are now able to learn complex tasks such as walking, running and jumping. The applications are endless, such as: inspection, search-and-rescue missions, entertainment and even healthcare. | ||
|
|
||
| >**Tasks that were once considered impossible for robots are now within reach, and the possibilities are endless. It's just a matter of time before we see robots performing tasks that were once only possible in science fiction.** | ||
|
|
||
|
|
@@ -113,31 +113,31 @@ Where: | |
| The robot is encouraged to track $w_z$ reference commanded by the user. | ||
|
|
||
| ```math | ||
| R_{ang\_vel} = \exp[-(w^{ref}_{z} - w_{z})^2] | ||
| R_{ang\_vel} = \exp[-(w^{cmd}_{z} - w^{base}_{z})^2] | ||
| ``` | ||
|
|
||
| Where: | ||
| - $w_{cmd,z}$ is the commanded yaw velocity. | ||
| - $w_{base,z}$ is the actual yaw velocity. | ||
| - $w^{cmd}_{z}$ is the commanded yaw velocity. | ||
| - $w^{base}_{z}$ is the actual yaw velocity. | ||
|
|
||
| #### 3. **Height Penalty** | ||
|
|
||
| The robot is encouraged to maintain a desired height as specified by the commanded altitude. A penalty is applied for deviations from this target height: | ||
|
|
||
| $$ | ||
| R_{z} = (z - z_{ref})^2 | ||
| P_{z} = (z - z_{ref})^2 | ||
| $$ | ||
|
|
||
| Where: | ||
| - $z$ is the current base height. | ||
| - $z_{ref}$ is the target height specified in the commands. | ||
|
|
||
| #### 4. **Pose Similarity Reward** | ||
| #### 4. **Pose Deviation Penalty** | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Here, I also changed the title to keep the consistency with the formula. |
||
|
|
||
| To keep the robot's joint poses close to a default configuration, a penalty is applied for large deviations from the default joint positions: | ||
|
|
||
| ```math | ||
| R_{pose\_similarity} = \|q - q_{default}\|^2 | ||
| P_{pose\_similarity} = \|q - q_{default}\|^2 | ||
| ``` | ||
|
|
||
| Where: | ||
|
|
@@ -149,29 +149,29 @@ Where: | |
| To ensure smooth control and discourage abrupt changes in actions, a penalty is applied based on the difference between consecutive actions: | ||
|
|
||
| ```math | ||
| R_{action\_rate} = \|a_{t} - a_{t-1}\|^2 | ||
| P_{action\_rate} = \|a_{t} - a_{t-1}\|^2 | ||
| ``` | ||
|
|
||
| Where: | ||
| - $a_t$ and $a_{t-1}$ are the actions at the current and previous time steps, respectively. | ||
|
|
||
| #### 6. **Vertical Velocity Penalty** | ||
|
|
||
| To discourage unnecessary movement along the vertical ($z$) axis, a penalty is applied to the squared $z$-axis velocity of the base when the robot is not actively jumping. The reward is: | ||
| To discourage unnecessary movement along the vertical ($z$) axis, a penalty is applied to the squared $z$-axis velocity of the base when the robot is not actively jumping. The penalty is: | ||
|
|
||
| ```math | ||
| R_{lin\_vel\_z} = v_{z}^2 | ||
| P_{lin\_vel\_z} = v_{z}^2 | ||
| ``` | ||
|
|
||
| Where: | ||
| - $v_{z}$ is the vertical velocity of the base. | ||
|
|
||
| #### 7. **Roll and Pitch Stabilization Penalty** | ||
|
|
||
| To ensure the robot maintains stability, a penalty is applied to discourage large roll and pitch deviations of the base. This reward is: | ||
| To ensure the robot maintains stability, a penalty is applied to discourage large roll and pitch deviations of the base. This penalty is: | ||
|
|
||
| ```math | ||
| R_{roll\_pitch} = roll^2 + pitch^2 | ||
| P_{roll\_pitch} = roll^2 + pitch^2 | ||
| ``` | ||
|
|
||
| Where: | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bit confusing, as the reward should be bigger when the robot is at the desired height, and smaller when it deviates from it. So, I think, we either need to change the formula (e.g.$\exp[-(z - z_{ref})^2])$ or keep the same formula but change the name of the variable to "penalty" instead of "reward" (basically, what the title suggests). I go with the second option, but I realize that it might add some confusion around the naming of the variables. Let me know what you think.