Replace EmbedIO with GenHTTP #862
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| [Route(HttpVerbs.Any, "/status")] | ||
| public void GetStatus() | ||
| [ResourceMethod(RequestMethod.Post, "bring-to-foreground")] | ||
| public void BringToForeground(IRequest request) |
There was a problem hiding this comment.
I think your logic could be simplified with a [FromBody] string? route argument.
There was a problem hiding this comment.
Hey, I did try this, but it seems routes may not be omitted even if declared nullable?
{
"status": 400,
"message": "Argument 'route' is expected to be read from the request body but the request does not contain any payload"
}There was a problem hiding this comment.
Hm, I would consider this a bug. Sorry, will fix this in the next version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the EmbedIO library with GenHTTP.
While we didn't have any specific issues with EmbedIO it is no long being developed and pretty much abandoned.
GenHTTP offers similar functionality while being a bit more modular, EmbedIO offered a lot of stuff we weren't using.
We now also got rid of the Swan.Lite library included with EmbedIO which added a lot of annoying extension methods on very broad things like
objectThis is very much a breaking change for plugins implementing their own controllers. However, any plugins that use the plugin endpoint API are unaffected by this change. I did drop support for
DataModelJsonPluginEndPoint, it was already marked as obsolete and while it probably would've worked with GenHTTP I didn't want to waste time on it.Oh, and it's about 30% faster at some rudimentary benchmarks I ran.