Repack (in place) unpacked chunks stored in RocksDB #639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldmberman
force-pushed
the
fix/repack-in-place-small-unpacked-chunks
branch
from
05b966b to
316a744
Compare
| ar_data_sync, StoreID) of | ||
| {Packing, Chunk, Offset, _, ChunkSize} = ChunkArgs, | ||
| StartOffset = Offset - ?DATA_CHUNK_SIZE, | ||
| RemoveFromSyncRecordResult = ar_sync_record:delete(Offset, |
Collaborator
There was a problem hiding this comment.
we remove here in expectation that we'll re-add the chunk to ar_data_sync record when handling the store_chunk` message?
JamesPiechota
force-pushed
the
feature/verify-tool-20241102
branch
from
811b9c5 to
8b04ee2
Compare
ldmberman
force-pushed
the
fix/repack-in-place-small-unpacked-chunks
branch
from
316a744 to
ac3a021
Compare
ldmberman
changed the base branch from
feature/verify-tool-20241102
to
master
JamesPiechota
changed the base branch from
master
to
release/performance-2.8
JamesPiechota
force-pushed
the
fix/repack-in-place-small-unpacked-chunks
branch
from
ac3a021 to
d8715e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.