Skip to content

Conversation

@ldmberman
Copy link
Member

No description provided.

@ldmberman ldmberman force-pushed the lb/flexible-solution-base branch from 003fe1b to 13a60cf Compare April 15, 2025 13:07
Solution2 ->
{PrevB, Solution2}
end;
pick_prev_block_for_solution3(Solution, Source, [], PrevBlocks) ->
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite follow why we need both pick_prev_block_for_solution2 and pick_prev_block_for_solution3?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pick_prev_block_for_solution2 looks for our blocks among the FrontBlocks

pick_prev_block_for_solution3 runs when there are none of our blocks in FrontBlocks, it goes block by block checking if we can put the new block on top; if there are no suitable blocks, it looks for our block among their (FrontBlock's) previous blocks

pick_prev_block_for_solution4 runs when there are none of our blocks among FrontBlock's previous blocks, it iterates over previous blocks

I will try to make it more readable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rearranged and renamed the functions

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ldmberman ldmberman force-pushed the lb/flexible-solution-base branch 2 times, most recently from 7206252 to 0b60ea0 Compare May 1, 2025 11:11
@ldmberman ldmberman force-pushed the lb/flexible-solution-base branch 2 times, most recently from 4386ac7 to 54cb890 Compare July 10, 2025 17:52
@ldmberman ldmberman force-pushed the lb/flexible-solution-base branch from 54cb890 to de90abb Compare July 17, 2025 12:19
Lev Berman added 2 commits July 17, 2025 21:44
Put each test in a separate module to ensure clean shutdown on CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants