-
Notifications
You must be signed in to change notification settings - Fork 230
Lb/sync replica 2 9 #812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ldmberman
wants to merge
98
commits into
master
Choose a base branch
from
lb/sync-replica-2-9
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lb/sync replica 2 9 #812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deed12b to
f72704b
Compare
Member
Author
|
A summary of the recent changes:
|
f2accdb to
391647e
Compare
66bd51b to
7587176
Compare
b9c681a to
64e57cd
Compare
34960ff to
5c9ad26
Compare
7f282f1 to
6e05931
Compare
2491973 to
e25c853
Compare
This reverts commit e8ab455.
This reverts commit be3b703.
Since it is primarily a wrapper around access to an ETS table the gen_server layer was causing some race conditions. Now that it's a striaght interface to ETS we can rely on ETS to resolve certain classes of race conditins (e.g. what happened before is a `put` was implemented as a `cast` and before the `cast` was processed a straight read from the ETS table was done and missed the put update)
when syncing data roots
Adding a new application in rebar3 tree requires specific files, at
least on arweave point of view. After the release is compiled, a github
job will create artifacts (to be reused in other jobs), but an error is
produced instead:
tar: ./_build/default/lib/arweave_diagnostic/include: File removed before we read it
tar: ./_build/default/lib/arweave_diagnostic/priv: File removed before we read it
tar: ./_build/default/rel/arweave/lib/arweave_diagnostic-0.0.1/include: File removed before we read it
tar: ./_build/default/rel/arweave/lib/arweave_diagnostic-0.0.1/priv: File removed before we read it
tar: ./_build/test/lib/arweave_diagnostic/include: File removed before we read it
tar: ./_build/test/lib/arweave_diagnostic/priv: File removed before we read it
tar: ./_build/test/rel/arweave/lib/arweave_diagnostic-0.0.1/include: File removed before we read it
tar: ./_build/test/rel/arweave/lib/arweave_diagnostic-0.0.1/priv: File removed before we read it
include and priv folders are required. Those must be present in the
github repository as well.
…nt count to avoid constant recalculating
also try to reduce some of the coordinator and peer_worker reductions be replacing gen_server:call with gen_server:cast and caching the formatted ppeer
…tprints" This reverts commit 19c9dee.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.