Add new Ranch metrics #928
Conversation
|
Please note, all connections is not max connections. |
| get_process_memory(ar_header_sync)}, | ||
| {ar_wallets_bytes_total, gauge, "ar_wallets process memory", | ||
| get_process_memory(ar_wallets)} | ||
| get_process_memory(ar_wallets)}, |
There was a problem hiding this comment.
I know this long predates your PR (and even predates my time on the project), But I think we can remove all of the message_queue_len and process memory metrics. Unles @humaite you use them for something?
We currently track process memory and message queue length for all processes (not just the ones mentioned here) via the ar_process_sampler module (when debug is on).
There was a problem hiding this comment.
No problem on my side. I'm currently also working on another tool to extract more information regarding all processes. I think we can remove it.
There was a problem hiding this comment.
I'll remove it. If we are updating this module, might as well.
JamesPiechota
left a comment
JamesPiechota
left a comment
There was a problem hiding this comment.
LGTM! But @humaite is more familiar with this area of the code, so I'd wait for him to complete a review.
Metrics of number of Ranch active connections, all connection, and acceptor processes.