Support AIC version 3

[dberlin]

Support new version of AIC used by M3

[marcan]

Is the only relevant difference the MAX_DIE field width? Can't we just reuse all the rest of the code and make that conditional / part of the regs struct?

[dberlin]

Yes.
The offsets are also now dynamic, and stored in the device tree, but they are the same between m2 and m3 max anyway.

So i could just add them to the struct and and make them -1, and we read the DT if they are -1.

Then we could share 2/3 init entirely.
Happy to go that way.

I'm also not positive they changed the max width for real. Or they have bugs.
I can see them always mask on the m2 with 0x7, and on the m3 it's 0xf.
But there are times they mask with 0x7 on the m3 as well (never on m2).

The max number of dies is 2 on m3 max, so if we left the field as-is, and left a comment, it would not break anything for now, since it fits easily in the field.

[marcan]

SGTM, let's go with that. I'm indifferent about the max dies thing, it's academic until a monster Mac Pro shows up (if ever), and that's guaranteed to need piles of code changes anyway.

[dberlin]

This is a take at it. I'm gonna install it in a second and test it - i also noticed a kboot thing that needed to be updated for aic3 and added it.

[dberlin]

This still works :)