Make macOS signing/DMG steps conditional on secret availability#137
Open
eddoww wants to merge 1 commit into
Open
Make macOS signing/DMG steps conditional on secret availability#137eddoww wants to merge 1 commit into
eddoww wants to merge 1 commit into
Conversation
eddoww
force-pushed
the
feature/optional-macos-signing
branch
3 times, most recently
from
8033683 to
75da1f2
Compare
Gate all signing, notarization, and DMG creation steps behind a step output that checks secrets.APPLE_CERT_P12 availability. Forks without Apple signing credentials can run the release workflow successfully - the macOS build still produces binaries, just no signed DMG.
eddoww
force-pushed
the
feature/optional-macos-signing
branch
from
75da1f2 to
5b51bcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release workflow currently fails on forks because the macOS signing steps blow up when Apple certificates aren't configured.
This adds a check step early in the macOS build job that tests if APPLE_CERT_P12 exists and sets an output flag. All signing/notarization/DMG steps are gated behind that flag. The DMG download in create-release uses continue-on-error and the checksum handles the missing file gracefully.
On upstream nothing changes. On forks without Apple certs, signing is skipped and the release is created without a DMG.