-
Notifications
You must be signed in to change notification settings - Fork 16
fix: normalize windows portable naming #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zouyonghe
merged 6 commits into
AstrBotDevs:main
from
zouyonghe:codex/windows-portable-followups
Apr 1, 2026
+299
−107
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
948d941
fix(ci): normalize windows portable naming
zouyonghe 3852988
test(ci): harden windows portable naming rules
zouyonghe 1379d63
fix(ci): validate windows portable file names
zouyonghe 02a052f
refactor(ci): extract windows portable naming helpers
zouyonghe 5c74552
refactor(testing): simplify windows portable helpers
zouyonghe cb84d1e
fix(ci): reject extra nightly components
zouyonghe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import re | ||
|
|
||
| WINDOWS_FILENAME_INVALID_CHARS_RE = re.compile(r'[<>:"/\\|?*]') | ||
| WINDOWS_FILENAME_INVALID_TRAILING_RE = re.compile(r"[ .]+$") | ||
| WINDOWS_RESERVED_DEVICE_NAMES = { | ||
| "CON", | ||
| "PRN", | ||
| "AUX", | ||
| "NUL", | ||
| *{f"COM{i}" for i in range(1, 10)}, | ||
| *{f"LPT{i}" for i in range(1, 10)}, | ||
| } | ||
|
|
||
|
|
||
| def validate_windows_filename(name: str) -> None: | ||
| if not name or name in {".", ".."}: | ||
| raise ValueError(f"invalid Windows filename: {name!r}") | ||
|
|
||
| if WINDOWS_FILENAME_INVALID_CHARS_RE.search(name): | ||
| raise ValueError( | ||
| f"invalid Windows filename {name!r}: contains characters invalid in Windows filenames" | ||
| ) | ||
|
|
||
| if WINDOWS_FILENAME_INVALID_TRAILING_RE.search(name): | ||
| raise ValueError( | ||
| f"invalid Windows filename {name!r}: trailing spaces or dots are not allowed" | ||
| ) | ||
|
|
||
| stem = name.split(".", 1)[0].upper() | ||
| if stem in WINDOWS_RESERVED_DEVICE_NAMES: | ||
| raise ValueError( | ||
| f"invalid Windows filename {name!r}: {stem!r} is a reserved device name" | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.