fetch latest enterprise appliance IPs from msd#3008
Conversation
tsultanov00
force-pushed
the
msd-updated-ips
branch
from
e5878ca to
098c997
Compare
| read(req, resource, params, config, callback) { | ||
| req.clients.msd.getWorkloadsByService( | ||
| { domainName: params.domainName, serviceName: params.serviceName }, | ||
| create(req, resource, params, body, config, callback) { |
There was a problem hiding this comment.
what is the idea behind switching from read to create request type? Are we doing any changes with this request on the backend?
There was a problem hiding this comment.
It wasn't initially documented, but from digging a bit further into the fetchr src code, there is a flag that we can use to allow POST requests with the read operation. I have made some changes to reflect this
tsultanov00
force-pushed
the
msd-updated-ips
branch
from
098c997 to
0c96024
Compare
| serviceNames: [serviceName], | ||
| }, | ||
| ], | ||
| resolveStaticWorkloads: true, |
There was a problem hiding this comment.
one small improvement: depending on the category we can set resolveStaticWorkloads/fetchDynamicTypeWorkloads to true/false.
If category is static then we do not look at the dynamic response so will be efficient if we set fetchDynamicTypeWorkloads to false and vice versa with fetchDynamicTypeWorkloads
There was a problem hiding this comment.
Good observation, I have made a change to reflect this
Signed-off-by: Timur Sultanov <timur.sultanov@yahooinc.com>
tsultanov00
force-pushed
the
msd-updated-ips
branch
from
0c96024 to
d5c9d0f
Compare
| onUpdateSuccess={this.props.onSubmit} | ||
| color={color} | ||
| key={item.uuid} | ||
| key={i} |
There was a problem hiding this comment.
uuid property doesn't exist under item, this gets rid of a react warning
Signed-off-by: Timur Sultanov <timur.sultanov@yahooinc.com>
4 participants
Description
Contribution Checklist:
Attach Screenshots (Optional)