forked from Roblox/nomad-driver-containerd
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upstream changes, user, go.mod #10
Open
jonathanrcross
wants to merge
21
commits into
AtomicConductor:master
Choose a base branch
from
Roblox:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add parameter to allow the setting of running user for container * use task level user param as source param
Signed-off-by: Shishir Mahajan <[email protected]>
* Fix issue #116 - allow relative paths in mounts. * Add test. Signed-off-by: Shishir Mahajan <[email protected]>
In case of entrypoint override, image config needs to be passed.
Signed-off-by: Shishir Mahajan <[email protected]>
Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.5.9 to 1.5.10. - [Release notes](https://github.com/containerd/containerd/releases) - [Changelog](https://github.com/containerd/containerd/blob/main/RELEASES.md) - [Commits](containerd/containerd@v1.5.9...v1.5.10) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Shishir Mahajan <[email protected]>
This PR upgrades dependencies By updating the go.mod build mode from 1.12 to 1.17 and upgrading directly imported dependencies, we can eliminate all of the 'replace' directives that were needed previously.
This PR updates the containerd driver to support changes in how Nomad manages cgroups when running on a machine using cgroups.v2 - The namespace is now set to "nomad.slice", which containerd uses as the cgroup parent. - The container name is re-oriented to the new naming convention, i.e. "<allocID>.<taskName>.scope". This is necessary for Nomad to be able to manage the cpuset resource.
Signed-off-by: Shishir Mahajan <[email protected]>
Bumps [github.com/opencontainers/runc](https://github.com/opencontainers/runc) from 1.1.0 to 1.1.2. - [Release notes](https://github.com/opencontainers/runc/releases) - [Changelog](https://github.com/opencontainers/runc/blob/v1.1.2/CHANGELOG.md) - [Commits](opencontainers/runc@v1.1.0...v1.1.2) --- updated-dependencies: - dependency-name: github.com/opencontainers/runc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/hashicorp/nomad](https://github.com/hashicorp/nomad) from 1.1.12 to 1.1.14. - [Release notes](https://github.com/hashicorp/nomad/releases) - [Changelog](https://github.com/hashicorp/nomad/blob/main/CHANGELOG.md) - [Commits](hashicorp/nomad@v1.1.12...v1.1.14) --- updated-dependencies: - dependency-name: github.com/hashicorp/nomad dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/containerd/containerd](https://github.com/containerd/containerd) from 1.6.1 to 1.6.6. Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Shishir Mahajan <[email protected]>
Signed-off-by: Shishir Mahajan <[email protected]>
Bumps [github.com/hashicorp/nomad](https://github.com/hashicorp/nomad) from 1.1.14 to 1.2.13. - [Release notes](https://github.com/hashicorp/nomad/releases) - [Changelog](https://github.com/hashicorp/nomad/blob/main/CHANGELOG.md) - [Commits](hashicorp/nomad@v1.1.14...v1.2.13) --- updated-dependencies: - dependency-name: github.com/hashicorp/nomad dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Shishir Mahajan <[email protected]>
Signed-off-by: Shishir Mahajan <[email protected]>
* Update deprecated API usage * upgrade nomad & containerd deps, use new cpustats interface --------- Co-authored-by: Marat Radchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.