#46 - Code optimizations

[Demosfen]

No description provided.

[Copilot]

Pull request overview

This PR implements comprehensive code optimizations focused on improving computational performance across the Geopack library. The optimizations target mathematical operations, memory allocation, and leverage modern .NET features including SIMD vectorization.

Key changes:

• Replaced Math.Pow(x, 2) with direct multiplication x * x for better performance
• Adopted Math.SinCos() to compute sine and cosine simultaneously, reducing redundant calculations
• Extracted magic numbers into well-documented constants in GeopackConstants.cs
• Implemented SIMD vectorization using Vector<double> for IGRF coefficient interpolation and extrapolation
• Refactored Newton's method iteration into a separate method for better code organization
• Optimized list initialization with capacity hints to reduce allocations

Reviewed changes

Copilot reviewed 32 out of 34 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/Geopack/Geopack.Trace.cs	Optimized list capacity, dot product calculation, and epsilon comparisons
src/Geopack/Geopack.T96Mgnp.cs	Replaced Math.Pow with multiplication, used Math.SinCos, extracted pressure factor constant
src/Geopack/Geopack.Sun.cs	Extracted constants, adopted Math.SinCos, improved epsilon comparisons
src/Geopack/Geopack.ShuMgnp.cs	Extracted model coefficients as constants, refactored Newton's method to private method, optimized trigonometric calculations
src/Geopack/Geopack.Recalc.cs	Implemented SIMD vectorization for coefficient processing, eliminated zero multiplications, cached repeated calculations
src/Geopack/Geopack.IgrfGsw.cs	Replaced Math.Pow with direct multiplication
src/Geopack/Geopack.IgrfGeo.cs	Adopted Math.SinCos for simultaneous trigonometric calculations
src/Geopack/Geopack.Dip.cs	Replaced Math.Pow with multiplication, cached repeated array accesses
src/ExternalFieldModels/T89/T89.cs	Adopted Math.SinCos
src/Contracts/Spherical/SphericalVector.cs	Minor formatting adjustment
src/Contracts/Spherical/SphericalLocation.cs	Cached trigonometric calculations to avoid recomputation
src/Contracts/Engine/GeopackConstants.cs	Added numerous well-documented constants for physics calculations and algorithm parameters
src/Contracts/Coordinates/GeodeticCoordinates.cs	Extracted WGS84 constants, replaced Math.Pow, adopted Math.SinCos
src/Contracts/Coordinates/GeocentricCoordinates.cs	Optimized iterative calculation with constant extraction and Math.SinCos
src/Contracts/Cartesian/CartesianVector.cs	Replaced Math.Pow with direct multiplication
Benchmark result files	Added performance measurement results documenting optimization impact
GeopackBenchmarks.cs	Most benchmarks commented out (appears to be work in progress)

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.