-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(s3stream): support config checking object integrity on aws client #915
base: main
Are you sure you want to change the base?
feat(s3stream): support config checking object integrity on aws client #915
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #915 +/- ##
============================================
+ Coverage 55.91% 55.92% +0.01%
- Complexity 1265 1266 +1
============================================
Files 133 133
Lines 8534 8534
Branches 789 789
============================================
+ Hits 4772 4773 +1
Misses 3327 3327
+ Partials 435 434 -1
|
CompletedPart.Builder builder = CompletedPart.builder().partNumber(partNumber).eTag(uploadPartResponse.eTag()); | ||
|
||
if (checksumForUpload != null) { | ||
switch (checksumForUpload) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about naming it checksumAlgorithmForUpload
directly? It's more understandable than checksumForUpload
.
And, I have another concern whether all the S3 cloud providers support this feature? Is there a simple way to check this issue? |
yeah I think the response header like "x-amz-checksum-algorithm" will indicate if the oss provider support this feature. I will try to figure this later. https://developers.cloudflare.com/r2/api/s3/api/ which is a case not support checksum. |
Great, please also be aware that we have moved s3stream to https://github.com/AutoMQ/automq, this repo will refer the s3stream module through |
No description provided.