Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): support config checking object integrity on aws client #915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lifepuzzlefun
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4dae71c) 55.91% compared to head (12c792b) 55.92%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #915      +/-   ##
============================================
+ Coverage     55.91%   55.92%   +0.01%     
- Complexity     1265     1266       +1     
============================================
  Files           133      133              
  Lines          8534     8534              
  Branches        789      789              
============================================
+ Hits           4772     4773       +1     
  Misses         3327     3327              
+ Partials        435      434       -1     
Components Coverage Δ
RocketMQ Broker ∅ <ø> (∅)
RocketMQ Common 5.80% <ø> (ø)
RocketMQ Controller 57.39% <ø> (ø)
RocketMQ Proxy 37.28% <ø> (+0.10%) ⬆️
RocketMQ Store 73.60% <0.00%> (-0.05%) ⬇️
RocketMQ Stream ∅ <ø> (∅)
RocketMQ Metadata 35.44% <ø> (ø)
Files Coverage Δ
.../java/com/automq/rocketmq/store/S3StreamStore.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@lifepuzzlefun
Copy link
Contributor Author

CompletedPart.Builder builder = CompletedPart.builder().partNumber(partNumber).eTag(uploadPartResponse.eTag());

if (checksumForUpload != null) {
switch (checksumForUpload) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about naming it checksumAlgorithmForUpload directly? It's more understandable than checksumForUpload.

@daniel-y
Copy link
Contributor

And, I have another concern whether all the S3 cloud providers support this feature? Is there a simple way to check this issue?

@lifepuzzlefun
Copy link
Contributor Author

yeah I think the response header like "x-amz-checksum-algorithm" will indicate if the oss provider support this feature. I will try to figure this later.

https://developers.cloudflare.com/r2/api/s3/api/ which is a case not support checksum.

@daniel-y
Copy link
Contributor

yeah I think the response header like "x-amz-checksum-algorithm" will indicate if the oss provider support this feature. I will try to figure this later.

https://developers.cloudflare.com/r2/api/s3/api/ which is a case not support checksum.

Great, please also be aware that we have moved s3stream to https://github.com/AutoMQ/automq, this repo will refer the s3stream module through git submodule

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants