perf(s3stream): cache parsed DataBlockIndex for IndexBlock #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
=========================================
Coverage 55.91% 55.91%
Complexity 1265 1265
=========================================
Files 133 133
Lines 8534 8534
Branches 789 789
=========================================
Hits 4772 4772
Misses 3327 3327
Partials 435 435
|
superhx
reviewed
Feb 18, 2024
| @@ -200,12 +200,14 @@ public static class IndexBlock { | |||
| private final ByteBuf buf; | |||
| private final int size; | |||
| private final int count; | |||
| private DataBlockIndex[] dataBlockIndices; | |||
There was a problem hiding this comment.
T he main considerations for parsing from buf are:
- Parsing the data block index is not frequent,
- Parsing from
bufhas a low cost. - Saving heap memory consumption.
If this becomes a CPU bottleneck, further optimization can be done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.