-
Notifications
You must be signed in to change notification settings - Fork 497
docs: Document custom header support for Table Topic REST catalogs #2934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
docs: Document custom header support for Table Topic REST catalogs #2934
Conversation
…log configuration This documentation explains how to configure custom HTTP headers for REST catalogs in AutoMQ Table Topic, specifically addressing Apache Polaris integration needs. Closes AutoMQ#2890
Adds a test case that demonstrates the Polaris-Realm header configuration functionality, addressing the specific use case mentioned in issue AutoMQ#2890.
|
Hi, @aaronseq12. Thank you for your contribution. However, as far as I know, there seems to be a similar test case targeting the same goal in the current codebase. Could you please clarify the differences and the necessity of your test case? Also, thank you for the additional documentation on Apache Polaris integration. The repository at https://github.com/AutoMQ/automq-labs/tree/main/table-topic-solutions would be a more appropriate place for this. You are welcome to provide related integration and docker-compose examples there. |
Hi @Gezi-lzq, thank you for your feedback! Let me address your concerns: Regarding the test case differences:Yes, There is a similar test case Existing test (
New test (
The new test serves as a concrete example for Polaris users and validates the specific use case that was requested. However, I understand your concern about the redundancy. Regarding documentation location:The Proposed changes:
Would you like me to update the PR with these changes? I can:
What do you think? |
The restPassthroughProperties() test already validates custom header functionality. Removing restWithPolarisRealmHeader() and RestCatalogMockForPolaris to avoid test redundancy as suggested in code review feedback.
Simplified documentation to focus on configuration pattern and point users to automq-labs repository for detailed integration examples as suggested in code review feedback.
Updates addedI've updated the PR based on your feedback: Changes Made:
Once this PR is merged, I'll create comprehensive Polaris integration examples with docker-compose setup in the |
Summary
This PR documents the existing custom header support for Table Topic REST catalog integrations, specifically addressing the Apache Polaris integration question raised in issue #2890.
Changes
Documentation
docs/table-topic-custom-headers.md
explaining:Addresses Code Review Feedback
restWithPolarisRealmHeader()
test as the existingrestPassthroughProperties()
test already validates custom header functionalityautomq-labs
repository for comprehensive integration examplesKey Features Documented
Configuration Pattern
Example Usage
Addresses Issue
Closes #2890 by documenting that custom header support already exists in AutoMQ. The functionality has been working since it was implemented and is already tested via
restPassthroughProperties()
, but was not well-documented for users.Testing
restPassthroughProperties()
validates header functionalityCompatibility
Next Steps
Detailed integration examples including Apache Polaris setup, docker-compose configurations, and troubleshooting guides will be added to the AutoMQ Labs repository as suggested by the maintainers.
This PR ensures that users can easily discover the existing custom header functionality while keeping the main repository documentation focused and pointing to the appropriate location for comprehensive examples.