Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen peer dependency range to include React 17 #320

Closed
Manoj-Bharti opened this issue Jul 13, 2021 · 4 comments · Fixed by #330
Closed

Widen peer dependency range to include React 17 #320

Manoj-Bharti opened this issue Jul 13, 2021 · 4 comments · Fixed by #330

Comments

@Manoj-Bharti
Copy link

Currently react-base-table only supports react-16

"peerDependencies": {
    "react": "^16.0.0",
    "react-dom": "^16.0.0"
  },

Could this be widened to ^16.0.0 || ^17.0.0?

@kachkaev
Copy link

@Manoj-Bharti have you tested the library with React 17? I know that it should all work fine in theory but it's probably best to have some data backing that.

I'm not a maintainer of this project, but I think that it'd be great if you could submit a PR with the tweak 🙂

@RickLucassen
Copy link
Contributor

We've been using this library with React 17 for 5 months now without any issues :), would love to see this updated. Might open a PR for it.

@Manoj-Bharti
Copy link
Author

@kachkaev Sorry for the late response, I was pretty occupied with other stuff and missed the notification of your comment. Also, I am too late now as @RickLucassen (thanks for that) already has PR ready for this 😄

@nihgwu
Copy link
Contributor

nihgwu commented Aug 8, 2021

Hey I believe it works fine with React 17, but I lost my access to this repo, for now you can just ignore the dependency warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants