Add support for React 17 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinashworth
added a commit
to kevinashworth/react-base-table
that referenced
this pull request
Sep 16, 2021
|
Are there any plans to merge this PR? I can confirm that's working perfect with react 17.x |
nihgwu
approved these changes
Oct 23, 2021
|
Thanks for contribution, I finally regain the permission to this repo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for React 17.
I've added version 17 to the
reactandreact-domentries within thepeerDependenciessection. Also upgraded them in thedevDependenciessection to make the tests run with React 17.This fixes #320.
We've been using react-base-table in combination with React 17 for a while now in our own project without any issues.