Updated Desktop Module with NovaWindows appium driver and LLM config fixes #54

teo-nikolov · 2025-11-18T15:35:20Z

No description provided.

…top-module-update # Conflicts: # src/Bellatrix.Desktop/components/Core/Component.DefaultActions.cs # src/Bellatrix.Desktop/settings/ExecutionSettings.cs

…experimental-desktop-driver # Conflicts: # src/Bellatrix.Core/Bellatrix.Core.csproj # src/Bellatrix.Desktop/Bellatrix.Desktop.csproj # src/Bellatrix.Desktop/components/Core/Component.cs # src/Bellatrix.Desktop/infrastructure/App.cs # src/Bellatrix.KeyVault/Bellatrix.KeyVault.csproj # src/Bellatrix.Web/Bellatrix.Web.csproj # src/Bellatrix.Web/plugins/execution/BrowserLifecyclePlugin.cs # src/Bellatrix.Web/services/DevToolsService.cs # templates/Bellatrix.API.GettingStarted/Models/Albums.cs # templates/Bellatrix.API.Tests/Models/Albums.cs # templates/Bellatrix.Desktop.Tests/TestsInitialize.cs # tests/Bellatrix.API.Tests/Models/Albums.cs

angelovstanton

please check comments

angelovstanton · 2025-12-16T10:02:46Z

src/Bellatrix.Desktop/services/WrappedWebDriverCreateService.cs

-    private static readonly string _serviceUrl;
+    private static readonly string ServiceUrl;
+
+    private const string CloseButtonXPath = "//Button[contains(translate(@AutomationId, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ', 'abcdefghijklmnopqrstuvwxyz'), 'close') or contains(translate(@Name, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ', 'abcdefghijklmnopqrstuvwxyz'), 'close')]";


this looks a bit strange is it correct?

It is the way to lowercase in XPath expression, it works in the example tests. Checks for 'close' automation id or name, case-insensitive

angelovstanton · 2025-12-16T10:03:06Z

src/Bellatrix.Desktop/infrastructure/App.cs

    // TODO: Change to be ThreadLocal.
    private static bool _shouldStartLocalService;
-    private static Process _winAppDriverProcess;
+    // private static Process _appiumProcess;


should we delete it?

yes, I'm using _appiumServerProcess below so this one is not needed

angelovstanton · 2025-12-16T10:03:38Z

src/Bellatrix.Desktop/infrastructure/App.cs

+            throw new ArgumentException("Appium version 3.1.0 or higher is required. Please update Appium by running: npm install -g appium@latest");
+        }
+
+        const string latestVersion = "1.2.0-preview.2";


is this versionm the correct one? should we move it somewhere in the config?

Yes, this will be needed only before we release the full 1.2.0 version, after that it will not be needed and will be automatically updated by appium

angelovstanton · 2025-12-16T10:04:17Z

src/Bellatrix.Desktop/components/Window.cs

+        Attached?.Invoke(this, new ComponentActionEventArgs(this));
+    }
+
+    // public virtual void Detach()


should we delete this one?

we can delete it, I changed the Attach logic so that we won't need to detach the windows to attach another one

angelovstanton · 2025-12-16T11:43:42Z

src/Bellatrix.Desktop/components/CheckBox.cs

+            Checking?.Invoke(this, new ComponentActionEventArgs(this));
+            try
+            {
+                WrappedDriver.ExecuteScript("windows: toggle", WrappedElement);


Will all of these JavaScript commands work across all desktop applications?

These are appium platform-specific extensions and are implemented in NovaWindows driver.

Whether they should work or not depends on if the component implements the correct Pattern (e.g. TogglePattern). If it does not, there's a fallback to the previous method.

angelovstanton · 2025-12-16T11:51:13Z

src/Bellatrix.Mobile/IOSPluginsConfiguration.cs

    {
        if (ConfigurationService.GetSection<LargeLanguageModelsSettings>() == null)
        {
-            throw new ArgumentException("Could not load LargeLanguageModelsSettings section from testFrameworkSettings.json");


maybe in all of the places we need to at least use the logger instead of just calling return?

angelovstanton · 2025-12-16T11:52:20Z

src/Bellatrix.Mobile/AndroidPluginsConfiguration.cs

        if (ConfigurationService.GetSection<LargeLanguageModelsSettings>() == null)
        {
-            throw new ArgumentException("Could not load LargeLanguageModelsSettings section from testFrameworkSettings.json");
+            return;


angelovstanton · 2025-12-16T11:52:39Z

src/Bellatrix.Web/WebPluginsConfiguration.cs

        if (ConfigurationService.GetSection<LargeLanguageModelsSettings>() == null)
        {
-            throw new ArgumentException("Could not load LargeLanguageModelsSettings section from testFrameworkSettings.json");
+            return;


upgrade nuget packages

…o experimental-desktop-driver

teo-nikolov and others added 26 commits November 19, 2023 23:09

updated Appium in desktop module

1c5f2f6

fixed warning messages in IDE

3901b9a

Desktop Module Update

f7a056c

Updates to the desktop module

b61128d

Merge remote-tracking branch 'origin/desktop-module-update' into desk…

f80b0d1

…top-module-update # Conflicts: # src/Bellatrix.Desktop/components/Core/Component.DefaultActions.cs # src/Bellatrix.Desktop/settings/ExecutionSettings.cs

reverted click default action

cb102c4

updated azure dependencies

c29358e

added SelectOption method to Menu component

7766b3f

removed case-sensitive folder

6d8a2a6

Fixed CheckBox.cs filename casing

40f1938

made WindowHandle virtual

71c7256

fixes for appium auto start

a051ee9

revert changes to process closing method

83bb762

Added experimental appium driver support

738adc2

fix warnings

8e210fb

fix errors

210ba1f

updates for Appium NovaWindows Driver installing

c7311de

Fixed possible null reference excepton

e39c4db

Updated packages

b86237f

Fixed for desktop module

71a1a84

Updated Desktop Components and Find Strategies

6ec910d

fixed prompt find strategies

d772e21

NovaWindows driver preview version bump

3065bc0

Disable self-healing locators and smart failure analysis by default

fecb2d6

Fix errors when LLM settings not exist in config

7af0882

teo-nikolov requested a review from angelovstanton November 18, 2025 15:35

angelovstanton requested changes Dec 16, 2025

View reviewed changes

angelovstanton added 2 commits December 16, 2025 15:23

update nuget packages

5d5ff67

fix build errors caused by automapper and appium upgrades

11d1ac4

angelovstanton and others added 7 commits December 16, 2025 15:47

update nugets

047d93b

upgrade .net version and language to .net 10

19d16c9

update MS related nugets

69a811b

fix build errors related to mstest upgrade

5bd4566

upgrade nuget packages

Fixed AppiumOptions initialization

5cf9add

Merge remote-tracking branch 'origin/experimental-desktop-driver' int…

ff42f02

…o experimental-desktop-driver

Comment fixes

3b6300d

Updated Desktop Module with NovaWindows appium driver and LLM config fixes #54

Are you sure you want to change the base?

Updated Desktop Module with NovaWindows appium driver and LLM config fixes #54

Uh oh!

Conversation

teo-nikolov commented Nov 18, 2025

Uh oh!

angelovstanton left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants