Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the usage of the 'manage_posts_custom_column' hook #1069

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix the usage of the 'manage_posts_custom_column' hook #1069

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions php/class-coauthors-plus.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,8 @@ public function admin_init(): void {
// Hooks to add additional co-authors to 'authors' column to edit page
add_filter( 'manage_posts_columns', array( $this, '_filter_manage_posts_columns' ) );
add_filter( 'manage_pages_columns', array( $this, '_filter_manage_posts_columns' ) );
add_action( 'manage_posts_custom_column', array( $this, '_filter_manage_posts_custom_column' ) );
add_action( 'manage_pages_custom_column', array( $this, '_filter_manage_posts_custom_column' ) );
add_action( 'manage_posts_custom_column', array( $this, '_filter_manage_posts_custom_column' ), 10, 2 );
add_action( 'manage_pages_custom_column', array( $this, '_filter_manage_posts_custom_column' ), 10, 2 );

// Add quick-edit co-author select field
add_action( 'quick_edit_custom_box', array( $this, '_action_quick_edit_custom_box' ), 10, 2 );
Expand Down Expand Up @@ -572,20 +572,21 @@ public function _filter_manage_posts_columns( $posts_columns ) {
/**
* Insert co-authors into post rows on Edit Page
*
* @param string $column_name
* @param string $column_name The name of the column in the list table
* @param int $post_id The ID of the current post in the list table
*/
public function _filter_manage_posts_custom_column( $column_name ): void {
public function _filter_manage_posts_custom_column( $column_name, $post_id ): void {
if ( 'coauthors' === $column_name ) {
global $post;
$authors = get_coauthors( $post->ID );
$authors = get_coauthors( $post_id );

$count = 1;
foreach ( $authors as $author ) :
$args = array(
'author_name' => $author->user_nicename,
);
if ( 'post' !== $post->post_type ) {
$args['post_type'] = $post->post_type;
$post_type = get_post_type($post_id);
if ( 'post' !== $post_type ) {
$args['post_type'] = $post_type;
}
$author_filter_url = add_query_arg( array_map( 'rawurlencode', $args ), admin_url( 'edit.php' ) );
?>
Expand Down