Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces the placeholder Jest smoke test with focused jsdom unit coverage for the onboarding wizard “Appearance” preview toggling script.
Changes:
- Added jsdom tests for
wizard-appearance.jscovering initialization, stale-markup correction, mode switching, and DOMContentLoaded timing. - Removed the no-op
jest runsplaceholder test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/js/wizard-appearance.test.js | Adds DOM-based unit tests for the wizard appearance preview/handle toggling behavior. |
| tests/js/fosse.test.js | Removes the placeholder Jest smoke test. |
Comment on lines
+25
to
+34
| function loadScript( readyState = 'complete' ) { | ||
| Object.defineProperty( document, 'readyState', { | ||
| value: readyState, | ||
| configurable: true, | ||
| } ); | ||
|
|
||
| jest.isolateModules( () => { | ||
| require( '../../src/Admin/assets/js/wizard-appearance.js' ); | ||
| } ); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Addressed in 2477202: loadScript() now captures the original document.readyState descriptor before overriding it and restores that descriptor in a finally block after requiring wizard-appearance.js. The DOMContentLoaded-path test still passes because the listener is registered during the temporary loading override.
Verified locally with:
pnpm test -- tests/js/wizard-appearance.test.jspnpm testpnpm run lintpnpm run format:check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing