Skip to content

Tests: tighten Bluesky handle normalization assertion#120

Open
RCowles wants to merge 1 commit intotrunkfrom
test/bluesky-handle-normalization-assertion
Open

Tests: tighten Bluesky handle normalization assertion#120
RCowles wants to merge 1 commit intotrunkfrom
test/bluesky-handle-normalization-assertion

Conversation

@RCowles
Copy link
Copy Markdown
Contributor

@RCowles RCowles commented May 10, 2026

Summary

  • Strengthen the leading-@ Bluesky connect test so it proves the normalized handle is passed to the authorize flow.
  • Assert the intercepted authorize URL contains alice.bsky.social and excludes both raw and URL-encoded @alice forms.

Testing

  • composer run-script test-php -- --filter test_handle_connect_strips_leading_at
  • composer run-script lint-php

Copilot AI review requested due to automatic review settings May 10, 2026 16:15
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Tightens the PHPUnit coverage around Bluesky handle normalization in the admin connect flow by asserting that a submitted leading-@ handle is normalized before being used in the upstream authorize/handle-resolution request.

Changes:

  • Updates the test_handle_connect_strips_leading_at test to assert the intercepted authorize/handle-resolution URL includes the normalized handle value.
  • Adds explicit negative assertions to ensure neither the raw @alice… form nor the URL-encoded %40alice… form is passed through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants