Skip to content

Conversation

@hippietrail
Copy link
Collaborator

@hippietrail hippietrail commented Sep 9, 2025

Issues

N/A

Description

(Work in progress)

  • Adds a command to normalize dictionary.dict.
  • (Will also add a command to audit dictionary.dict and annotations.json.)

How Has This Been Tested?

Manual testing

Checklist

  • I have performed a self-review of my own code
  • I have added tests to cover my changes

Comment on lines 1030 to 1031
// result.extend(pos_map.get(pos_flag_char).unwrap());
// let props = pos_map.get(pos_flag_char).unwrap();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented code means it was a left behind debug, or some idea that was tried and is unresolved for now

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented code means it was a left behind debug, or some idea that was tried and is unresolved for now

This is still a draft. I should've put "work in progress" in the description.

Comment on lines 950 to 957
let pos_tags = "NOVJRIPCD";
let noun_props = "09gmw";
let verb_props = "lAbdGtT6h";
let pron_props = "aso123F";
let adj_props = "^cuY*.:";
let det_props = "qM5";
let noun_and_verb_props = "S";
let verb_and_adj_props = ">";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it means you have to maintain annotations.json and this at the same time?

I might be wrong, but if not, I'm a bit worried.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it means you have to maintain annotations.json and this at the same time?

I might be wrong, but if not, I'm a bit worried.

I think I'll add fields to annotation.json to enable pulling these out programmatically. Still developing this feature...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pre-AI-era image I made ages ago, and I cherish

395770858-718c5a79-c97e-4a60-bb00-c543221e328f.jpg

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(-: Feedback is still cool.

@hippietrail
Copy link
Collaborator Author

I can't find a way to get rid of all the merge commits from this PR, other than making a new clean PR. So #2133 replaces this PR.

@hippietrail hippietrail closed this Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants