-
Notifications
You must be signed in to change notification settings - Fork 235
feat: harper-cli normalize-dictionary
#1892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: harper-cli normalize-dictionary
#1892
Conversation
harper-cli/src/main.rs
Outdated
| // result.extend(pos_map.get(pos_flag_char).unwrap()); | ||
| // let props = pos_map.get(pos_flag_char).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented code means it was a left behind debug, or some idea that was tried and is unresolved for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented code means it was a left behind debug, or some idea that was tried and is unresolved for now
This is still a draft. I should've put "work in progress" in the description.
harper-cli/src/main.rs
Outdated
| let pos_tags = "NOVJRIPCD"; | ||
| let noun_props = "09gmw"; | ||
| let verb_props = "lAbdGtT6h"; | ||
| let pron_props = "aso123F"; | ||
| let adj_props = "^cuY*.:"; | ||
| let det_props = "qM5"; | ||
| let noun_and_verb_props = "S"; | ||
| let verb_and_adj_props = ">"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it means you have to maintain annotations.json and this at the same time?
I might be wrong, but if not, I'm a bit worried.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it means you have to maintain annotations.json and this at the same time?
I might be wrong, but if not, I'm a bit worried.
I think I'll add fields to annotation.json to enable pulling these out programmatically. Still developing this feature...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(-: Feedback is still cool.
…ctionary-normalize-and-audit
…tionary-normalize-and-audit
…tionary-normalize-and-audit
|
I can't find a way to get rid of all the merge commits from this PR, other than making a new clean PR. So #2133 replaces this PR. |

Issues
N/A
Description
(Work in progress)
dictionary.dict.dictionary.dictandannotations.json.)How Has This Been Tested?
Manual testing
Checklist