feat: adding prefixes to dictionary #2212
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
Inspired by the second point in #2203
Description
Annotating prefixes in the dictionary and annotations.
Since many prefixes are not also words, this doesn't add any prefixes, it just annotates the ones that are already there due to also being words.
But I've added a comment for each prefix that is not also a word to dissuade contributors from adding them.
Adding them to the dictionary would cause them not to be flagged by the spellchecker.
If/when we need a way to handle all prefixes that would be best done with something like a
SequenceExpr::WordSetin addition to an.is_prefix()Knowing about prefixes will help modify the current
MergeWordslinter and/orMergeableWordsexpression, or add equivalent ones that would be able to deal with things like "re-read", "re read", "dis like", etc.So far I've never seen the same mistake in the wild made with suffixes. Since I can't think of a need for suffix support yet, I've only added the barest skeleton of it in the
DictWordMetadata.Checklist