-
Notifications
You must be signed in to change notification settings - Fork 235
Irregular verbs #2285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Irregular verbs #2285
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5434941
chore: start working on irregular plural module
hippietrail 3c5d46d
feat: irregular verb module
hippietrail 4c5ee0c
fix: `will_non_lemma.rs` shouldn't be included here
hippietrail 84546fd
fix: `just format`
hippietrail 0489f93
Merge branch 'master' of https://github.com/Automattic/harper into ir…
hippietrail 360bfc7
refactor: in response to PR feedback
hippietrail 4445a29
fix: implement @elijah's requested changes
hippietrail 07375dc
Merge branch 'master' of https://github.com/Automattic/harper into ir…
hippietrail File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| [ | ||
| "// comments can appear in the line before an entry", | ||
| "// or in place of an entry", | ||
| ["child", "children"], | ||
| ["foot", "feet"], | ||
| ["goose", "geese"], | ||
| ["man", "men"], | ||
| ["mouse", "mice"], | ||
| ["ox", "oxen"], | ||
| ["person", "people"], | ||
| ["seraph", "seraphim"], | ||
| ["woman", "women"], | ||
| ["addendum", "addenda"], | ||
| ["aircraft", "aircraft"], | ||
| ["aircraftman", "aircraftmen"], | ||
| ["aircraftwoman", "aircraftwomen"], | ||
| ["airman", "airmen"], | ||
| ["alderman", "aldermen"], | ||
| ["alga", "algae"], | ||
| ["alveolus", "alveoli"], | ||
| ["anchorman", "anchormen"], | ||
| ["anchorwoman", "anchorwomen"], | ||
| ["atrium", "atria"], | ||
| ["axis", "axes"], | ||
| ["bacillus", "bacilli"], | ||
| ["bacterium", "bacteria"], | ||
| ["bandsman", "bandsmen"], | ||
| ["bargeman", "bargemen"], | ||
| ["bellman", "bellmen"], | ||
| ["biceps", "biceps"], | ||
| ["boatman", "boatmen"], | ||
| ["bronchus", "bronchi"], | ||
| ["businesswoman", "businesswomen"], | ||
| ["cactus", "cacti"], | ||
| ["cameraperson", "camerapeople"], | ||
| ["candelabrum", "candelabra"], | ||
| ["catharsis", "catharses"], | ||
| ["chairman", "chairmen"], | ||
| ["chairwoman", "chairwomen"], | ||
| ["churchwoman", "churchwomen"], | ||
| ["clansman", "clansmen"], | ||
| ["clanswoman", "clanswomen"], | ||
| ["committeeman", "committeemen"], | ||
| ["committeewoman", "committeewomen"], | ||
| ["continuum", "continua"], | ||
| ["corpus", "corpora"], | ||
| ["craftsman", "craftsmen"], | ||
| ["craftswoman", "craftswomen"], | ||
| ["crisis", "crises"], | ||
| ["cyclops", "cyclopes"], | ||
| ["datum", "data"], | ||
| ["diaeresis", "diaereses"], | ||
| ["diagnosis", "diagnoses"], | ||
| ["dominatrix", "dominatrices"], | ||
| ["draughtsman", "draughtsmen"], | ||
| ["draughtswoman", "draughtswomen"], | ||
| ["effluvium", "effluvia"], | ||
| ["emphasis", "emphases"], | ||
| ["esophagus", "esophagi"], | ||
| ["extremum", "extrema"], | ||
| ["fish", "fish"], | ||
| ["footman", "footmen"], | ||
| ["formula", "formulae"], | ||
| ["forum", "fora"], | ||
| ["freeman", "freemen"], | ||
| ["frontiersman", "frontiersmen"], | ||
| ["frontierswoman", "frontierswomen"], | ||
| ["garbageman", "garbagemen"], | ||
| ["genesis", "geneses"], | ||
| ["genie", "genii"], | ||
| ["genius", "genii"], | ||
| ["genus", "genera"], | ||
| ["glissando", "glissandi"], | ||
| ["graffito", "graffiti"], | ||
| ["grandchild", "grandchildren"], | ||
| ["handyman", "handymen"], | ||
| ["hitman", "hitmen"], | ||
| ["houseman", "housemen"], | ||
| ["iceman", "icemen"], | ||
| ["ilium", "ilia"], | ||
| ["index", "indices"], | ||
| ["intermezzo", "intermezzi"], | ||
| ["journeyman", "journeymen"], | ||
| ["labium", "labia"], | ||
| ["lamina", "laminae"], | ||
| ["laundrywoman", "laundrywomen"], | ||
| ["laywoman", "laywomen"], | ||
| ["linesman", "linesmen"], | ||
| ["lira", " lire"], | ||
| ["longshoreman", "longshoremen"], | ||
| ["louse", "lice"], | ||
| ["madman", "madmen"], | ||
| ["mailman", "mailmen"], | ||
| ["memorandum", "memoranda"], | ||
| ["metathesis", "metatheses"], | ||
| ["minimum", "minima"], | ||
| ["mitosis", "mitoses"], | ||
| ["motorman", "motormen"], | ||
| ["muscleman", "musclemen"], | ||
| ["nemesis", "nemeses"], | ||
| ["nightwatchman", "nightwatchmen"], | ||
| ["oarsman", "oarsmen"], | ||
| ["oarswoman", "oarswomen"], | ||
| ["oasis", "oases"], | ||
| ["ombudsman", "ombudsmen"], | ||
| ["optimum", "optima"], | ||
| ["palazzo", "palazzi"], | ||
| ["papyrus", "papyri"], | ||
| ["parenthesis", "parentheses"], | ||
| ["patina", "patinae"], | ||
| ["patrolman", "patrolmen"], | ||
| ["pericardium", "pericardia"], | ||
| ["periphrasis", "periphrases"], | ||
| ["pharynx", "pharynges"], | ||
| ["phenomenon", "phenomena"], | ||
| ["plainclothesman", "plainclothesmen"], | ||
| ["pneumococcus", "pneumococci"], | ||
| ["pressman", "pressmen"], | ||
| ["prosthesis", "protheses"], | ||
| ["quantum", "quanta"], | ||
| ["radius", "radii"], | ||
| ["radix", "radices"], | ||
| ["repairman", "repairmen"], | ||
| ["salesman", "salesmen"], | ||
| ["saleswoman", "saleswomen"], | ||
| ["sandman", "sandmen"], | ||
| ["schema", "schemata"], | ||
| ["sheep", "sheep"], | ||
| ["shoreman", "shoremen"], | ||
| ["signore", "signori"], | ||
| ["simulacrum", "simulacra"], | ||
| ["solarium", "solaria"], | ||
| ["spokesman", "spokesmen"], | ||
| ["spokesperson", "spokespeople"], | ||
| ["spokeswoman", "spokeswomen"], | ||
| ["statesman", "statesmen"], | ||
| ["stateswoman", "stateswomen"], | ||
| ["steersman", "steersmen"], | ||
| ["stratum", "strata"], | ||
| ["streptococcus", "streptococci"], | ||
| ["succubus", "succubi"], | ||
| ["symbiosis", "symbioses"], | ||
| ["tarsus", "tarsi"], | ||
| ["taxon", "taxa"], | ||
| ["testatrix", "testatrices"], | ||
| ["testis", "testes"], | ||
| ["thesis", "theses"], | ||
| ["thrombosis", "thromboses"], | ||
| ["tooth", "teeth"], | ||
| ["townsman", "townsmen"], | ||
| ["townswoman", "townswomen"], | ||
| ["tradesman", "tradesmen"], | ||
| ["tradeswoman", "tradeswomen"], | ||
| ["uterus", "uteri"], | ||
| ["vertebra", "vertebrae"], | ||
| ["vertex", "vertices"], | ||
| ["vivarium", "vivaria"], | ||
| ["washerwoman", "washerwomen"], | ||
| ["woodlouse", "woodlice"], | ||
| ["workingwoman", "workingwomen"], | ||
| ["workman", "workmen"] | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| [ | ||
| "// comments can appear in the line before an entry", | ||
| "// or in place of an entry", | ||
| ["arise", "arose", "arisen"], | ||
| ["awake", "awoke", "awoken"], | ||
| "// be/am/are/is -- was/were -- been", | ||
| ["become", "became", "become"], | ||
| ["begin", "began", "begun"], | ||
| ["bend", "bent", "bent"], | ||
| ["bet", "bet", "bet"], | ||
| ["bid", "bade", "bidden"], | ||
| ["bind", "bound", "bound"], | ||
| ["bite", "bit", "bitten"], | ||
| ["bleed", "bled", "bled"], | ||
| ["blow", "blew", "blown"], | ||
| ["break", "broke", "broken"], | ||
| ["breed", "bred", "bred"], | ||
| ["bring", "brought", "brought"], | ||
| ["build", "built", "built"], | ||
| ["burst", "burst", "burst"], | ||
| ["buy", "bought", "bought"], | ||
| ["catch", "caught", "caught"], | ||
| ["choose", "chose", "chosen"], | ||
| ["come", "came", "come"], | ||
| ["cost", "cost", "cost"], | ||
| ["cut", "cut", "cut"], | ||
| ["dive", "dove", "dove"], | ||
| ["do", "did", "done"], | ||
| ["drink", "drank", "drunk"], | ||
| ["drive", "drove", "driven"], | ||
| ["eat", "ate", "eaten"], | ||
| ["fall", "fell", "fallen"], | ||
| ["feed", "fed", "fed"], | ||
| ["feel", "felt", "felt"], | ||
| ["fight", "fought", "fought"], | ||
| ["find", "found", "found"], | ||
| ["fly", "flew", "flown"], | ||
| ["forget", "forgot", "forgotten"], | ||
| ["forgo", "forwent", "forgone"], | ||
| ["freeze", "froze", "frozen"], | ||
| "// get -- got -- gotten", | ||
| ["get", "got", "got"], | ||
| ["give", "gave", "given"], | ||
| ["go", "went", "gone"], | ||
| ["grow", "grew", "grown"], | ||
| ["have", "had", "had"], | ||
| ["hear", "heard", "heard"], | ||
| ["hit", "hit", "hit"], | ||
| ["hold", "held", "held"], | ||
| ["hurt", "hurt", "hurt"], | ||
| ["input", "input", "input"], | ||
| ["keep", "kept", "kept"], | ||
| ["know", "knew", "known"], | ||
| ["lay", "laid", "lain"], | ||
| ["lead", "led", "led"], | ||
| ["light", "lit", "lit"], | ||
| ["lose", "lost", "lost"], | ||
| ["make", "made", "made"], | ||
| ["mistake", "mistook", "mistaken"], | ||
| ["output", "output", "output"], | ||
| ["overtake", "overtook", "overtaken"], | ||
| ["overthrow", "overthrew", "overthrown"], | ||
| ["overwrite", "overwrote", "overwritten"], | ||
| ["partake", "partook", "partaken"], | ||
| ["pay", "paid", "paid"], | ||
| ["put", "put", "put"], | ||
| ["read", "read", "read"], | ||
| ["redo", "redid", "redone"], | ||
| ["remake", "remade", "remade"], | ||
| ["reread", "reread", "reread"], | ||
| ["reset", "reset", "reset"], | ||
| ["ride", "rode", "ridden"], | ||
| ["ring", "rang", "rung"], | ||
| ["rise", "rose", "risen"], | ||
| ["run", "ran", "run"], | ||
| ["see", "saw", "seen"], | ||
| ["sell", "sold", "sold"], | ||
| ["send", "sent", "sent"], | ||
| ["set", "set", "set"], | ||
| ["shake", "shook", "shaken"], | ||
| ["shed", "shed", "shed"], | ||
| ["shine", "shone", "shone"], | ||
| ["shoe", "shod", "shod"], | ||
| ["shoot", "shot", "shot"], | ||
| ["show", "showed", "shown"], | ||
| ["shrink", "shrank", "shrunk"], | ||
| ["shut", "shut", "shut"], | ||
| ["sing", "sang", "sung"], | ||
| "// sink -- sank -- sunken??", | ||
| ["sink", "sank", "sunk"], | ||
| ["sit", "sat", "sat"], | ||
| ["slay", "slew", "slain"], | ||
| ["sleep", "slept", "slept"], | ||
| ["slide", "slid", "slid"], | ||
| ["slit", "slit", "slit"], | ||
| "// sneak -- sneaked/snuck -- sneaked/snuck", | ||
| ["speak", "spoke", "spoken"], | ||
| ["spin", "spun", "spun"], | ||
| ["spit", "spat", "spat"], | ||
| ["split", "split", "split"], | ||
| ["spread", "spread", "spread"], | ||
| ["spring", "sprang", "sprung"], | ||
| ["stand", "stood", "stood"], | ||
| ["steal", "stole", "stolen"], | ||
| ["stick", "stuck", "stuck"], | ||
| ["sting", "stung", "stung"], | ||
| ["stink", "stank", "stunk"], | ||
| ["stride", "strode", "stridden"], | ||
| ["strike", "struck", "stricken"], | ||
| ["string", "strung", "strung"], | ||
| ["sew", "sewed", "sewn"], | ||
| ["swear", "swore", "sworn"], | ||
| ["swim", "swam", "swum"], | ||
| ["swing", "swung", "swung"], | ||
| ["take", "took", "taken"], | ||
| ["teach", "taught", "taught"], | ||
| ["tear", "tore", "torn"], | ||
| ["think", "thought", "thought"], | ||
| ["throw", "threw", "thrown"], | ||
| ["tread", "trod", "trodden"], | ||
| ["undo", "undid", "undone"], | ||
| ["wake", "woke", "woken"], | ||
| ["wear", "wore", "worn"], | ||
| ["weave", "wove", "woven"], | ||
| ["wind", "wound", "wound"], | ||
| ["write", "wrote", "written"] | ||
| ] | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I adore the idea of having a dedicating file for this, similar to the dictionary. I'd like to centralize all data files, though. Would you mind moving this next to the
dictionary.dict?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. And there's also
irregular_nouns.jsonnow.