refactor: made a new lint_group from two mass noun linters
#2290
+90
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| pub use merge_rule_hidden::MassNouns; | ||
|
|
||
| mod merge_rule_hidden { |
Collaborator
There was a problem hiding this comment.
Where does the need for module come from? Why not just expose the struct as-is?
Collaborator
Author
There was a problem hiding this comment.
Where does the need for module come from? Why not just expose the struct as-is?
Still learning Rust and still learning Harper internals. Didn't have a good handle on all the hows and whys of mod used as it was inside the macro.
…ss-noun-improvements
elijah-potter
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
I was investigating something our mass noun linting doesn't flag and realized there are two linters:
MassPluralsandNounCountability.I've put them together into a new
lint_group. It's the first one that takes an extra parameter (dictionary in this case) which makes it a good example for future contributors.How Has This Been Tested?
I added a couple of unit tests to the
mod.rsto make sure the two member linters work via the new lint group,Checklist