feat: more abbreviation expansions #2310
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
N/A
Description
Adds a few more abbreviation expansions:
args → argument was already linted but I added unit tests for it too.
But there is one problem:
The
lints_sol_clean_correctlytest on fileharper-comments/tests/language_support_sources/clean.solcontains this line:This
paramgets flagged. But should it? Is that line considered code or comment?The test is expected to have no lints:
But since it's clean I guess I shouldn't bump that to
1But if this
paramshouldn't be corrected I'm also reluctant to change the file toAnyone have any advice?
How Has This Been Tested?
A unit test from GitHub or elsewhere on the Intenet for each variant.
Checklist