-
Notifications
You must be signed in to change notification settings - Fork 819
Jetpack SEO: fix useSelect call #43023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
Full summary · PHP report · JS report Coverage check overridden by
Coverage tests to be added later
|
Since I still see the warning with this PR, I created another that does remove the warning but is made without full context of the feature itself: #43031 |
Closed in favor of a better (and actually working) solution in #43031 |
Proposed changes:
This PR changes the useSelect call on useSeoRequests hook to be more in line with performant practices
Other information:
Jetpack product discussion
p1744303609023589-slack-C02TQF5VAJD
Does this pull request change what data or activity we track or use?
No
Testing instructions:
TBD