Hides the Blaze badge on the Stats page when the feature is disabled #43048

sbarbosa · 2025-04-11T20:04:07Z

Fixes Automattic/wp-calypso#101987

We are displaying the Blaze link on the Stats page when the Blaze feature is off; if users click it, they will end up on an invalid page. The main problem is that the site and user connection are now handled separately, and it's more common to land on this case. (Blaze needs both connections to work correctly).

Proposed changes:

Include the can_blaze flag as one of the initial parameters for the Jetpack Stats module (Odyssey app).

Note for Reviewers: Because of a phan error, I had to include the blaze package as a dependency in the Stats. Please let me know if there are different ways to do this. I guarded my code in case the stats module is working on a standalone solution.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

N/A

Does this pull request change what data or activity we track or use?

No

Testing instructions:

You will need to have a site with some stats, so try to access the posts a couple of times before starting the test.

Access any self-hosted and navigate to Jetpack->Stats
Verify that you see the Blaze badge on any of the posts from the "Post & Pages" section:
Now disconnect your user from WPCOM (just the user)
Go back to Jetpack->Stats and verify that you no longer see the Blaze Badge.

github-actions · 2025-04-11T20:04:59Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/blaze-badge-stats-page branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/blaze-badge-stats-page

bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/blaze-badge-stats-page

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-04-11T20:05:07Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
WoA releases happen weekly.
Releases to self-hosted sites happen monthly:
- Scheduled release: May 6, 2025
- Code freeze: May 5, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Mu Wpcom plugin:

Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-04-11T20:16:45Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/stats-admin/src/class-odyssey-config-data.php	110/112 (98.21%)	0.03%	0 💚

Full summary · PHP report · JS report

…s-page

timur987

Thanks @sbarbosa!

The code LGTM and works as advertised.

For next reviewers

Using a local Jetpack is not the best way to test this PR because when I tried it I wasn't able to bring views there even after waiting for significant amount of time and trying various devices (tried accessing a post from phone, using VPN and so on).

Instead, please use a one-time Jurassic Ninja site together with Beta Tester plugin (link) by putting a feature branch as on the image below.

Side note

Even though what I want to mention is far beyond this PR, it still should be mentioned.
I noticed that blaze icon is shown for posts but is not shown for pages as on a gif below.

timur987 · 2025-04-14T09:28:26Z

projects/packages/stats-admin/src/class-odyssey-config-data.php

@@ -40,6 +40,8 @@ public function get_data() {
 		$blog_id = Jetpack_Options::get_option( 'id' );
 		$host    = new Host();

+		$can_blaze = class_exists( 'Automattic\Jetpack\Blaze' ) && \Automattic\Jetpack\Blaze::should_initialize()['can_init'] === true;


I see Phan static analysis gone mad and returned according error.

I found that there's a way to calm it a bit. Previously folks used this approach to make it happier: https://github.com/Automattic/jetpack/pull/41857/files

Yes, I changed how I guard the code and explicitly use an if wrapper. I still had to add the blaze package in the composer.

I will update the ticket to mention that so I can get feedback from the Jetapck team if I need to solve that problem differently.

therocket-gr

tested using a jurrasic site and worked as described
code changes LGTM

Hides the Blaze badge on the Stats page when the feature is disabled

84ffbf9

sbarbosa requested a review from kangzj April 11, 2025 20:04

sbarbosa added [Status] Needs Review This PR is ready for review. [Package] Stats Admin Bug labels Apr 11, 2025

sbarbosa self-assigned this Apr 11, 2025

sbarbosa requested review from therocket-gr and timur987 April 11, 2025 20:05

github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Apr 11, 2025

sbarbosa removed the request for review from kangzj April 11, 2025 20:14

sbarbosa added [Status] In Progress and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Apr 11, 2025

sbarbosa removed request for therocket-gr and timur987 April 11, 2025 20:58

timur987 and others added 2 commits April 14, 2025 12:07

Merge remote-tracking branch 'origin/trunk' into fix/blaze-badge-stat…

38ebfce

…s-page

Improves Blaze guard check

2f60537

github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh labels Apr 14, 2025

timur987 approved these changes Apr 14, 2025

View reviewed changes

sbarbosa requested review from therocket-gr and kangzj April 14, 2025 13:21

sbarbosa added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels Apr 14, 2025

github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Apr 14, 2025

therocket-gr approved these changes Apr 14, 2025

View reviewed changes

sbarbosa added [Status] Needs Review This PR is ready for review. [Type] Bug When a feature is broken and / or not performing as intended and removed Bug [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Apr 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hides the Blaze badge on the Stats page when the feature is disabled #43048

Hides the Blaze badge on the Stats page when the feature is disabled #43048

sbarbosa commented Apr 11, 2025 •

edited

Loading

github-actions bot commented Apr 11, 2025 •

edited

Loading

github-actions bot commented Apr 11, 2025 •

edited

Loading

jp-launch-control bot commented Apr 11, 2025 •

edited

Loading

timur987 left a comment

timur987 Apr 14, 2025

sbarbosa Apr 14, 2025

therocket-gr left a comment

Hides the Blaze badge on the Stats page when the feature is disabled #43048

Are you sure you want to change the base?

Hides the Blaze badge on the Stats page when the feature is disabled #43048

Conversation

sbarbosa commented Apr 11, 2025 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Apr 11, 2025 • edited Loading

github-actions bot commented Apr 11, 2025 • edited Loading

jp-launch-control bot commented Apr 11, 2025 • edited Loading

Code Coverage Summary

timur987 left a comment

Choose a reason for hiding this comment

For next reviewers

Side note

timur987 Apr 14, 2025

Choose a reason for hiding this comment

sbarbosa Apr 14, 2025

Choose a reason for hiding this comment

therocket-gr left a comment

Choose a reason for hiding this comment

sbarbosa commented Apr 11, 2025 •

edited

Loading

github-actions bot commented Apr 11, 2025 •

edited

Loading

github-actions bot commented Apr 11, 2025 •

edited

Loading

jp-launch-control bot commented Apr 11, 2025 •

edited

Loading