Skip to content

Forms: Update feedback email template #43323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025
Merged

Conversation

enejb
Copy link
Member

@enejb enejb commented Apr 30, 2025

Resolves FORMS-40

This PR updates the email template that is send to admins when someone submits the form.

We are doing this so that the email that goes out look a more modern. The current email template does not apply any styles so the emails. So fonts and such look dated.

This PR is a revert or a revert ( + bug fixes )
This version of the email template doesn't include the subject line in the email copy so that it doesn't show up twice in some email clients.

Before:
Screenshot 2025-05-01 at 10 39 38 AM

After:
Screenshot 2025-05-01 at 10 41 08 AM

Proposed changes:

  • Update the design to look more modern.
  • Add a footer linking to jetpack forms.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

No

Testing instructions:

On a jurassic.ninja site or a hosted jetpack site. Apply this branch.

  • Create a form. Insert it into a page or post.
  • Fill out the form.
  • Check the email that get sent to the admin across different email client. Mobile and desktop.
  • Notice that it looks good across them.

@github-actions github-actions bot added [Feature] Contact Form [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ labels Apr 30, 2025
Copy link
Contributor

github-actions bot commented Apr 30, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Jetpack plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 30, 2025
Copy link
Contributor

github-actions bot commented Apr 30, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/feedback-emails-take-2 branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/feedback-emails-take-2

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link

jp-launch-control bot commented Apr 30, 2025

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/contact-form/templates/email-response.php 0/9 (0.00%) 0.00% 7 💔
projects/packages/forms/src/contact-form/class-contact-form.php 556/861 (64.58%) -0.04% 0 💚

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@enejb enejb requested a review from a team April 30, 2025 22:18
@enejb enejb added [Status] Needs Review This PR is ready for review. [Status] Needs Team Review Obsolete. Use Needs Review instead. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Review This PR is ready for review. labels May 1, 2025
@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 1, 2025
@simison simison force-pushed the update/feedback-emails-take-2 branch from 1a14971 to 5bdb39f Compare May 2, 2025 11:57
@simison
Copy link
Member

simison commented May 2, 2025

Rebased for testing

Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, the double subject in previous (reverted) version, which in some email clients would indeed end up right above each other:

Screenshot 2025-05-02 at 15 11 20

New version in this PR:

Screenshot 2025-05-02 at 15 11 40

Trunk without this change:

Screenshot 2025-05-02 at 15 12 08

@simison simison added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label May 6, 2025
@simison simison force-pushed the update/feedback-emails-take-2 branch from 5bdb39f to bb2ff14 Compare May 6, 2025 16:09
@simison
Copy link
Member

simison commented May 6, 2025

Rebased, @enejb I think this is ready to go?

@enejb enejb merged commit b22914c into trunk May 6, 2025
66 checks passed
@enejb enejb deleted the update/feedback-emails-take-2 branch May 6, 2025 17:16
@github-actions github-actions bot removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] Needs Team Review Obsolete. Use Needs Review instead. labels May 6, 2025
@simison simison added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Contact Form I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Package] Forms [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants