-
Notifications
You must be signed in to change notification settings - Fork 825
Add typecheck script to all the workspaces that use TypeScript #44795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds TypeScript type-checking capabilities to all workspaces that use TypeScript but were previously missing the typecheck script. This ensures consistent type validation across the entire codebase.
- Add standardized
"typecheck": "tsc --noEmit"
script to package.json files - Include TypeScript as a dev dependency where needed
- Create tsconfig.json for shared-extension-utils package
- Update TypeScript version in external-media package to align with project standards
Reviewed Changes
Copilot reviewed 39 out of 40 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
projects/plugins/inspect/package.json | Adds typecheck script to inspect plugin |
projects/plugins/crm/package.json | Adds typecheck script to CRM plugin |
projects/plugins/boost/package.json | Adds typecheck script to Boost plugin |
projects/packages/videopress/package.json | Adds typecheck script to VideoPress package |
projects/packages/subscribers-dashboard/package.json | Adds typecheck script to subscribers dashboard |
projects/packages/plugin-deactivation/package.json | Adds typecheck script to plugin deactivation package |
projects/packages/external-media/package.json | Updates TypeScript version to 5.8.3 |
projects/packages/explat/package.json | Adds typecheck script to explat package |
projects/packages/backup/package.json | Adds typecheck script to backup package |
projects/js-packages/*/package.json | Adds typecheck scripts and TypeScript dependencies to various JS packages |
projects/js-packages/shared-extension-utils/tsconfig.json | Creates TypeScript configuration file |
/changelog/ | Adds changelog entries for all modified packages |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Boost plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Inspect plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Classic Theme helper plugin plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
projects/packages/backup/src/js/components/review-request/stories/index.stories.tsx
Show resolved
Hide resolved
projects/packages/videopress/changelog/add-typecheck-script-to-ts-workspaces
Outdated
Show resolved
Hide resolved
projects/plugins/boost/changelog/add-typecheck-script-to-ts-workspaces
Outdated
Show resolved
Hide resolved
projects/plugins/crm/changelog/add-typecheck-script-to-ts-workspaces
Outdated
Show resolved
Hide resolved
projects/js-packages/boost-score-api/changelog/add-typecheck-script-to-ts-workspaces
Outdated
Show resolved
Hide resolved
projects/packages/videopress/changelog/add-typecheck-script-to-ts-workspaces
Outdated
Show resolved
Hide resolved
Co-authored-by: tbradsha <[email protected]>
Following #44787, I noticed that there are many other workspaces that use TypeScript but are not type-checked. This PR addresses that.
Proposed changes:
plugins/crm
,packages/videopress
andplugins/boost
as they need extra effort to fix TS errors. Boost can be a bit challenging as it's a complete mess of a TS setup.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: