Skip to content

Media Uploader: Restrict unsupported files from being uploaded #44798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: trunk
Choose a base branch
from

Conversation

claudiucelfilip
Copy link
Contributor

@claudiucelfilip claudiucelfilip commented Aug 14, 2025

Fixes DOTOBRD-293

Proposed changes:

  • adds the unsupported media types to the media uploader section so that the users don't need to wait for the file to upload to discover it's not supported

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to '..'
  • Create a WoA dev pool site with Personal/Premium
  • rsync the changes to the site
  • go to /wp-admin/media-new.php
  • video (and other unsupported) files should not be selectable in the file browser
Screenshot 2025-08-18 at 16 09 17

@claudiucelfilip claudiucelfilip marked this pull request as draft August 14, 2025 13:07
Copy link
Contributor

github-actions bot commented Aug 14, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the update/restrict-files-upload-summer-special branch.

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Aug 14, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • 🔴 Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Aug 14, 2025
Copy link

jp-launch-control bot commented Aug 14, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/plugins/wpcomsh/feature-plugins/hooks.php 24/164 (14.63%) -2.27% 22 💔

Full summary · PHP report

Coverage check overridden by Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code .

@claudiucelfilip claudiucelfilip force-pushed the update/restrict-files-upload-summer-special branch from e219dfc to 7069ce1 Compare August 15, 2025 13:23
@claudiucelfilip claudiucelfilip force-pushed the update/restrict-files-upload-summer-special branch from f1a67b2 to 16eb110 Compare August 18, 2025 11:21
@claudiucelfilip claudiucelfilip self-assigned this Aug 18, 2025
@claudiucelfilip claudiucelfilip added the [Status] Needs Review This PR is ready for review. label Aug 18, 2025
@claudiucelfilip claudiucelfilip requested a review from a team August 18, 2025 13:13
@claudiucelfilip claudiucelfilip removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. [Status] In Progress labels Aug 18, 2025
@github-actions github-actions bot added [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Aug 18, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restricts file selection in the WordPress media uploader to prevent users from selecting unsupported media types (video/audio) based on their site's features, providing immediate feedback without requiring upload attempts.

  • Adds client-side file type filtering using Plupload to restrict selectable files based on site features
  • Implements feature-based restrictions for audio files (UPLOAD_AUDIO_FILES) and video files (VIDEOPRESS)
  • Registers the restrictions only when the media library is enqueued to avoid affecting other upload contexts

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
projects/plugins/wpcomsh/feature-plugins/hooks.php Implements Plupload file filtering logic and registration
projects/plugins/wpcomsh/changelog/update-restrict-files-upload-summer-special Adds changelog entry for the feature
Comments suppressed due to low confidence (1)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

$options['filters'] = array();
}
$options['filters']['mime_types'] = array(
array( 'extensions' => implode( ',', $allowed_extensions ) ),
Copy link
Preview

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hardcoded 'mime_types' key assumes a specific Plupload filter structure. Consider checking if this key already exists and merging with existing filters to avoid overwriting user-defined filters.

Suggested change
array( 'extensions' => implode( ',', $allowed_extensions ) ),
// Merge with existing mime_types filters if present
$merged_extensions = $allowed_extensions;
if ( isset( $options['filters']['mime_types'] ) && is_array( $options['filters']['mime_types'] ) ) {
foreach ( $options['filters']['mime_types'] as $filter ) {
if ( isset( $filter['extensions'] ) ) {
$existing_exts = explode( ',', $filter['extensions'] );
$merged_extensions = array_merge( $merged_extensions, $existing_exts );
}
}
$merged_extensions = array_values( array_unique( $merged_extensions ) );
}
$options['filters']['mime_types'] = array(
array( 'extensions' => implode( ',', $merged_extensions ) ),

Copilot uses AI. Check for mistakes.

@claudiucelfilip claudiucelfilip marked this pull request as ready for review August 18, 2025 13:31
@claudiucelfilip claudiucelfilip changed the title WIP: Update/restrict files upload summer special Media Uploader: Restrict unsupported files from being uploaded Aug 18, 2025
@claudiucelfilip claudiucelfilip added Enhancement Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code and removed [Status] In Progress [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Aug 18, 2025
@github-actions github-actions bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Covered by non-unit tests Use to ignore the Code coverage requirement check when E2Es or other non-unit tests cover the code Enhancement [Plugin] Wpcomsh [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant