Contact form: lower specificity in the editor to match the frontend

[MaggieCabrera]

The frontend has a 0,0,0 specificity for the CSS that can be changed by the user, whereas the editor has a 0,1,0. This is not a problem today, but it will be an issue when WordPress/gutenberg#70378 gets merged. The GB PR aims to add the ability to style inputs via the elements API with theme.json. It works out of the box for Jetpack with the current styles but only in the frontend, the editor is still too specific. This PR aligns the two so it will work when the GB changes land.

Frontend:

Editor:

Proposed changes:

Maintained the same selectors but moved the :where() to encase all of it instead of partially to fit the specificity requirement

Other information:

• Have you written new tests for your changes, if applicable?
• Have you checked the E2E test CI results, and verified that your changes do not break them?
• Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

• Insert a contact form, inspect the styles for inputs in the editor and frontend. The specificity should be the same
• Check that custom user styles still apply correctly.

If possible, test with the GB PR active too:

• Change your theme.json to have changes such as

"elements": {
			"textInput": {
				"border": {
					"radius": "0",
					"style": "solid",
					"width": "1px",
					"color": "red"
				},
				"color": {
					"text": "blue"
				},
				"typography": {
					"fontFamily": "var(--wp--preset--font-family--inter)"
				}
			},
}

• The input's border should have changed to be red both in the frontend and the editor (prior to this PR the editor would not reflect the changes)

[github-actions]

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

• To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the try-form-specificity branch.
• To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack try-form-specificity

Interested in more tips and information?

• In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
• Read more about our development workflow here: PCYsg-eg0-p2
• Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

[github-actions]

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

• ✅ Include a description of your PR changes.
  
• ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  
• ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  
• ✅ Add testing instructions.
  
• ✅ Specify whether this PR includes any changes to data or privacy.
  
• ✅ Add changelog entries to affected projects
  

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

---

Follow this PR Review Process:

1. Ensure all required checks appearing at the bottom of this PR are passing.
2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
3. You can use GitHub's Reviewers functionality to request a review.
4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

[jp-launch-control]

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

[simison]

Please feel free to ask reviews from Zap team (and "jetpack-forms" on Slack) when you want more eyes on this. Zenith team might also be interested to take a look as they recently solved too high specificity issues in Forms. Thanks!

[MaggieCabrera]

This also aligns with the frontend styles. I couldn't see a reason why it had to be styled differently

[enejb]

In my testing it worked well.

I noticed some discrepancies between textarea and the regular text input.

between the editor and the frontend view. But they are there in trunk already.

From my testing this change seems safe to make.